Fix warning for unsaved work on beforeUnload

Review Request #8635 - Created Jan. 19, 2017 and submitted

Kanghee Park
Review Board
master
4084
3df832f...
reviewboard, students

Previously, when editing a review or comments as a user without
edit rights, warning users about losing unsaved work did not get
displayed.

Now the ReviewRequestEditorView's beforeUnload event handler does
not check a user's edit rights and only checks to see if any
fields are being edited at the moment.

New unit tests testing the onBeforeUnload event handler has been
added.

Ran JS unit tests.
Check that ReviewDialogView for both edit and non-edit privileged users are
warned before unloading.

  • 0
  • 17
  • 3
  • 20
Description From Last Updated
Review Bot
Barret Rennie
Kanghee Park
Kanghee Park
Review Bot
Kanghee Park
Christian Hammond
Kanghee Park
Review Bot
Kanghee Park
Review Bot
Barret Rennie
Christian Hammond
Kanghee Park
Review Bot
David Trowbridge
Kanghee Park
Review Bot
David Trowbridge
Kanghee Park
Review Bot
David Trowbridge
Kanghee Park
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (176916d)
Loading...