Convert checklist javascript to ES6.
Review Request #8628 — Created Jan. 17, 2017 and submitted
This change converts the various javascript files in the checklist extension to
use ES6, including proper documentation for everything. I've cleaned up the
code a bit, but there will probably be a lot of refactoring later as I
integrate some of the student work that's been sitting around.
Smoke tested checklist features.
| Description | From | Last Updated |
|---|---|---|
|
We're not actually defining anything locally here., so we shouldn't need this? |
brennie
|
|
|
Too many blank lines. |
brennie
|
|
|
new Model().save() ? |
brennie
|
|
|
Again this is unnecessary. |
brennie
|
|
|
Well, it returns the data unmodified. |
brennie
|
|
|
This too. |
brennie
|
|
|
Blank line between these. |
brennie
|
|
|
Blank line between these. |
brennie
|
|
|
Here too. |
brennie
|
|
|
Indented too far? |
brennie
|
Review request changed
- Commit:
-
f9c02a0dfc7ce9617e2b9e587273ac046b9b6d2d41ebdec6c9a0f385958c18a4a2f5c8d9d867a02e
- Diff:
-
Revision 2 (+930 -751)
-
Tool: Pyflakes Processed Files: rbchecklist/rbchecklist/extension.py Ignored Files: rbchecklist/rbchecklist/static/js/models/checklist.js rbchecklist/rbchecklist/static/js/models/checklistTemplateModel.es6.js rbchecklist/rbchecklist/static/js/views/checklistView.es6.js rbchecklist/rbchecklist/static/js/models/checklistTemplate.js rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.es6.js rbchecklist/rbchecklist/static/js/models/checklistModel.es6.js rbchecklist/rbchecklist/static/js/views/checklistView.js rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.js Tool: PEP8 Style Checker Processed Files: rbchecklist/rbchecklist/extension.py Ignored Files: rbchecklist/rbchecklist/static/js/models/checklist.js rbchecklist/rbchecklist/static/js/models/checklistTemplateModel.es6.js rbchecklist/rbchecklist/static/js/views/checklistView.es6.js rbchecklist/rbchecklist/static/js/models/checklistTemplate.js rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.es6.js rbchecklist/rbchecklist/static/js/models/checklistModel.es6.js rbchecklist/rbchecklist/static/js/views/checklistView.js rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.js
Tool: Pyflakes Processed Files: rbchecklist/rbchecklist/extension.py Ignored Files: rbchecklist/rbchecklist/static/js/models/checklist.js rbchecklist/rbchecklist/static/js/models/checklistTemplateModel.es6.js rbchecklist/rbchecklist/static/js/views/checklistView.es6.js rbchecklist/rbchecklist/static/js/models/checklistTemplate.js rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.es6.js rbchecklist/rbchecklist/static/js/models/checklistModel.es6.js rbchecklist/rbchecklist/static/js/views/checklistView.js rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.js Tool: PEP8 Style Checker Processed Files: rbchecklist/rbchecklist/extension.py Ignored Files: rbchecklist/rbchecklist/static/js/models/checklist.js rbchecklist/rbchecklist/static/js/models/checklistTemplateModel.es6.js rbchecklist/rbchecklist/static/js/views/checklistView.es6.js rbchecklist/rbchecklist/static/js/models/checklistTemplate.js rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.es6.js rbchecklist/rbchecklist/static/js/models/checklistModel.es6.js rbchecklist/rbchecklist/static/js/views/checklistView.js rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.js