Summary

Convert checklist javascript to ES6.

Review Request #8628 — Created Jan. 17, 2017 and submitted Jan. 21, 2017, 2:47 p.m.

Information

Owner

david

Repository

rb-extension-pack

Branch

master

Bugs

Depends On

Commit

41ebdec...

Reviewers

Groups

rb-extension-pack

People

Description

This change converts the various javascript files in the checklist extension to
use ES6, including proper documentation for everything. I've cleaned up the
code a bit, but there will probably be a lot of refactoring later as I
integrate some of the student work that's been sitting around.

Testing Done

Smoke tested checklist features.

Issues

Description	From	Last Updated
We're not actually defining anything locally here., so we shouldn't need this?	brennie	Jan. 21, 2017, 2:07 p.m.
Too many blank lines.	brennie	Jan. 21, 2017, 2:07 p.m.
new Model().save() ?	brennie	Jan. 21, 2017, 2:07 p.m.
Again this is unnecessary.	brennie	Jan. 21, 2017, 2:08 p.m.
Well, it returns the data unmodified.	brennie	Jan. 21, 2017, 2:08 p.m.
This too.	brennie	Jan. 21, 2017, 2:08 p.m.
Blank line between these.	brennie	Jan. 21, 2017, 2:08 p.m.
Blank line between these.	brennie	Jan. 21, 2017, 2:08 p.m.
Here too.	brennie	Jan. 21, 2017, 2:08 p.m.
Indented too far?	brennie	Jan. 21, 2017, 2:14 p.m.

Tool: Pyflakes
Processed Files:
    rbchecklist/rbchecklist/extension.py

Ignored Files:
    rbchecklist/rbchecklist/static/js/models/checklist.js
    rbchecklist/rbchecklist/static/js/models/checklistTemplateModel.es6.js
    rbchecklist/rbchecklist/static/js/views/checklistView.es6.js
    rbchecklist/rbchecklist/static/js/models/checklistTemplate.js
    rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.es6.js
    rbchecklist/rbchecklist/static/js/models/checklistModel.es6.js
    rbchecklist/rbchecklist/static/js/views/checklistView.js
    rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.js



Tool: PEP8 Style Checker
Processed Files:
    rbchecklist/rbchecklist/extension.py

Ignored Files:
    rbchecklist/rbchecklist/static/js/models/checklist.js
    rbchecklist/rbchecklist/static/js/models/checklistTemplateModel.es6.js
    rbchecklist/rbchecklist/static/js/views/checklistView.es6.js
    rbchecklist/rbchecklist/static/js/models/checklistTemplate.js
    rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.es6.js
    rbchecklist/rbchecklist/static/js/models/checklistModel.es6.js
    rbchecklist/rbchecklist/static/js/views/checklistView.js
    rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.js

Ship it!

rbchecklist/rbchecklist/static/js/models/checklistModel.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
We're not actually defining anything locally here., so we shouldn't need this?
```
rbchecklist/rbchecklist/static/js/models/checklistModel.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Too many blank lines.
```

rbchecklist/rbchecklist/static/js/models/checklistModel.es6.js (Diff revision 1)

The issue has been dropped. Show all issues

new Model().save() ?

david Jan. 21, 2017, 2:14 p.m.

I'd rather keep it separate for formatting purposes.

rbchecklist/rbchecklist/static/js/models/checklistTemplateModel.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Again this is unnecessary.
```
rbchecklist/rbchecklist/static/js/models/checklistTemplateModel.es6.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Well, it returns the data unmodified.
```
rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
This too.
```

rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

Blank line between these.

rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

Blank line between these.

rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

Here too.

rbchecklist/rbchecklist/static/js/views/checklistView.es6.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Indented too far?
```
1. david Jan. 21, 2017, 2:14 p.m.
  Nope, because .children() is returning a nested selector.

Commit:

f9c02a0dfc7ce9617e2b9e587273ac046b9b6d2d

41ebdec6c9a0f385958c18a4a2f5c8d9d867a02e

Diff:

Revision 2 (+930 -751)

Show changes

	rbchecklist/rbchecklist/extension.py
	rbchecklist/rbchecklist/static/js/models/checklist.js
	rbchecklist/rbchecklist/static/js/models/checklistModel.es6.js
	rbchecklist/rbchecklist/static/js/models/checklistTemplate.js
	rbchecklist/rbchecklist/static/js/models/checklistTemplateModel.es6.js
	rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.js
	rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.es6.js
	rbchecklist/rbchecklist/static/js/views/checklistView.js
	1 more

Tool: Pyflakes
Processed Files:
    rbchecklist/rbchecklist/extension.py

Ignored Files:
    rbchecklist/rbchecklist/static/js/models/checklist.js
    rbchecklist/rbchecklist/static/js/models/checklistTemplateModel.es6.js
    rbchecklist/rbchecklist/static/js/views/checklistView.es6.js
    rbchecklist/rbchecklist/static/js/models/checklistTemplate.js
    rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.es6.js
    rbchecklist/rbchecklist/static/js/models/checklistModel.es6.js
    rbchecklist/rbchecklist/static/js/views/checklistView.js
    rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.js



Tool: PEP8 Style Checker
Processed Files:
    rbchecklist/rbchecklist/extension.py

Ignored Files:
    rbchecklist/rbchecklist/static/js/models/checklist.js
    rbchecklist/rbchecklist/static/js/models/checklistTemplateModel.es6.js
    rbchecklist/rbchecklist/static/js/views/checklistView.es6.js
    rbchecklist/rbchecklist/static/js/models/checklistTemplate.js
    rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.es6.js
    rbchecklist/rbchecklist/static/js/models/checklistModel.es6.js
    rbchecklist/rbchecklist/static/js/views/checklistView.js
    rbchecklist/rbchecklist/static/js/views/checklistAccountPageView.js

Status:: Completed
Change Summary:: Pushed to master (8135eef)