Move checklist view instantiation into pure JS.

Review Request #8621 — Created Jan. 16, 2017 and submitted

Information

rb-extension-pack
master
d21d64b...

Reviewers

The way that the checklist view was created and added to the page was pretty
out of date. I've updated it to use the PageManager to wait until the page is
ready and then fetch the review request ID from that. The view is then created
and added to the page like we do with pretty much everything else, instead of
creating a dummy element and having the view add itself.

Loaded the page and saw the checklist was visible.

Description From Last Updated

'TemplateHook' imported but unused

reviewbotreviewbot
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbchecklist/setup.py
        rbchecklist/rbchecklist/extension.py
    
    Ignored Files:
        rbchecklist/rbchecklist/static/js/views/checklistView.js
        rbchecklist/rbchecklist/static/js/checklist.es6.js
        rbchecklist/rbchecklist/templates/checklist/template.html
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbchecklist/setup.py
        rbchecklist/rbchecklist/extension.py
    
    Ignored Files:
        rbchecklist/rbchecklist/static/js/views/checklistView.js
        rbchecklist/rbchecklist/static/js/checklist.es6.js
        rbchecklist/rbchecklist/templates/checklist/template.html
    
    
  2. rbchecklist/rbchecklist/extension.py (Diff revision 1)
     
     
     'TemplateHook' imported but unused
    
  3. 
      
david
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbchecklist/setup.py
        rbchecklist/rbchecklist/extension.py
    
    Ignored Files:
        rbchecklist/rbchecklist/static/js/views/checklistView.js
        rbchecklist/rbchecklist/static/js/checklist.es6.js
        rbchecklist/rbchecklist/templates/checklist/template.html
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbchecklist/setup.py
        rbchecklist/rbchecklist/extension.py
    
    Ignored Files:
        rbchecklist/rbchecklist/static/js/views/checklistView.js
        rbchecklist/rbchecklist/static/js/checklist.es6.js
        rbchecklist/rbchecklist/templates/checklist/template.html
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (e3559f4)
Loading...