Move checklist view instantiation into pure JS.
Review Request #8621 — Created Jan. 16, 2017 and submitted
The way that the checklist view was created and added to the page was pretty
out of date. I've updated it to use thePageManagerto wait until the page is
ready and then fetch the review request ID from that. The view is then created
and added to the page like we do with pretty much everything else, instead of
creating a dummy element and having the view add itself.
Loaded the page and saw the checklist was visible.
| Description | From | Last Updated |
|---|---|---|
|
'TemplateHook' imported but unused |
 reviewbot
|
-
Tool: PEP8 Style Checker Processed Files: rbchecklist/setup.py rbchecklist/rbchecklist/extension.py Ignored Files: rbchecklist/rbchecklist/static/js/views/checklistView.js rbchecklist/rbchecklist/static/js/checklist.es6.js rbchecklist/rbchecklist/templates/checklist/template.html Tool: Pyflakes Processed Files: rbchecklist/setup.py rbchecklist/rbchecklist/extension.py Ignored Files: rbchecklist/rbchecklist/static/js/views/checklistView.js rbchecklist/rbchecklist/static/js/checklist.es6.js rbchecklist/rbchecklist/templates/checklist/template.html
Tool: PEP8 Style Checker Processed Files: rbchecklist/setup.py rbchecklist/rbchecklist/extension.py Ignored Files: rbchecklist/rbchecklist/static/js/views/checklistView.js rbchecklist/rbchecklist/static/js/checklist.es6.js rbchecklist/rbchecklist/templates/checklist/template.html Tool: Pyflakes Processed Files: rbchecklist/setup.py rbchecklist/rbchecklist/extension.py Ignored Files: rbchecklist/rbchecklist/static/js/views/checklistView.js rbchecklist/rbchecklist/static/js/checklist.es6.js rbchecklist/rbchecklist/templates/checklist/template.html