Add bugs_closed field in matching for guessing review id on `rbt post --update`
Review Request #8611 — Created Jan. 11, 2017 and updated
Information | |
---|---|
AlexTalker | |
RBTools | |
master | |
Reviewers | |
rbtools | |
Company I work for using review board a lot, and it's a good tool. I noticed that if I change summary of review, it will be rare first in match when rbt tries to guess review id. Also, as my expirience says, it is rare that bugs_closed field gets changed over changes on task. So, I guess it will be good if guessing will depend not only on summary & description, but also on bugs_closed field.
AL
-
-
rbtools/utils/match_score.py (Diff revision 1) One improvement which can be made is sorting of values here before compare, since it usually doesn't matter on bugs list itself, but matter on match ratio.

-
Tool: Pyflakes Processed Files: rbtools/utils/match_score.py rbtools/commands/post.py rbtools/utils/review_request.py Tool: PEP8 Style Checker Processed Files: rbtools/utils/match_score.py rbtools/commands/post.py rbtools/utils/review_request.py
-