Add bugs_closed field in matching for guessing review id on `rbt post --update`

Review Request #8611 — Created Jan. 12, 2017 and updated

AlexTalker
RBTools
master
rbtools

Company I work for using review board a lot, and it's a good tool. I noticed that if I change summary of review, it will be rare first in match when rbt tries to guess review id. Also, as my expirience says, it is rare that bugs_closed field gets changed over changes on task. So, I guess it will be good if guessing will depend not only on summary & description, but also on bugs_closed field.



Description From Last Updated

Col: 35 E221 multiple spaces before operator

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (86 > 79 characters)

reviewbotreviewbot

Col: 66 W291 trailing whitespace

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/utils/match_score.py
        rbtools/commands/post.py
        rbtools/utils/review_request.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/utils/match_score.py
        rbtools/commands/post.py
        rbtools/utils/review_request.py
    
    
  2. rbtools/utils/match_score.py (Diff revision 1)
     
     
    Col: 35
     E221 multiple spaces before operator
    
  3. rbtools/utils/match_score.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (80 > 79 characters)
    
  4. rbtools/utils/review_request.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (86 > 79 characters)
    
  5. 
      
AL
  1. 
      
  2. rbtools/utils/match_score.py (Diff revision 1)
     
     
     

    One improvement which can be made is sorting of values here before compare, since it usually doesn't matter on bugs list itself, but matter on match ratio.

  3. 
      
AL
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/utils/match_score.py
        rbtools/commands/post.py
        rbtools/utils/review_request.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/utils/match_score.py
        rbtools/commands/post.py
        rbtools/utils/review_request.py
    
    
  2. rbtools/utils/match_score.py (Diff revision 2)
     
     
    Col: 66
     W291 trailing whitespace
    
  3. 
      
AL
Review request changed
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/utils/match_score.py
        rbtools/commands/post.py
        rbtools/utils/review_request.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/utils/match_score.py
        rbtools/commands/post.py
        rbtools/utils/review_request.py
    
    
  2. 
      
Loading...