Summary

Add bugs_closed field in matching for guessing review id on `rbt post --update`

Review Request #8611 — Created Jan. 12, 2017 and updated Jan. 12, 2017, 1:55 a.m.

Information

Owner

AlexTalker

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Company I work for using review board a lot, and it's a good tool. I noticed that if I change summary of review, it will be rare first in match when rbt tries to guess review id. Also, as my expirience says, it is rare that bugs_closed field gets changed over changes on task. So, I guess it will be good if guessing will depend not only on summary & description, but also on bugs_closed field.

Testing Done

Issues

Description	From	Last Updated
Col: 35 E221 multiple spaces before operator	reviewbot	Jan. 12, 2017, 1:53 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Jan. 12, 2017, 1:53 a.m.
Col: 80 E501 line too long (86 > 79 characters)	reviewbot	Jan. 12, 2017, 1:53 a.m.
Col: 66 W291 trailing whitespace	reviewbot	Jan. 12, 2017, 1:55 a.m.

Tool: Pyflakes
Processed Files:
    rbtools/utils/match_score.py
    rbtools/commands/post.py
    rbtools/utils/review_request.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/match_score.py
    rbtools/commands/post.py
    rbtools/utils/review_request.py

rbtools/utils/match_score.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 35
 E221 multiple spaces before operator
```
rbtools/utils/match_score.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/review_request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (86 > 79 characters)
```

rbtools/utils/match_score.py (Diff revision 1)

One improvement which can be made is sorting of values here before compare, since it usually doesn't matter on bugs list itself, but matter on match ratio.

Change Summary:

Fix code style issues.

Diff:

Revision 2 (+37 -19)

Show changes

	rbtools/commands/post.py
	rbtools/utils/match_score.py
	rbtools/utils/review_request.py

Tool: Pyflakes
Processed Files:
    rbtools/utils/match_score.py
    rbtools/commands/post.py
    rbtools/utils/review_request.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/match_score.py
    rbtools/commands/post.py
    rbtools/utils/review_request.py

rbtools/utils/match_score.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 66
 W291 trailing whitespace
```

Change Summary:

Fix code style one more time.

Diff:

Revision 3 (+37 -19)

Show changes

	rbtools/commands/post.py
	rbtools/utils/match_score.py
	rbtools/utils/review_request.py

Tool: Pyflakes
Processed Files:
    rbtools/utils/match_score.py
    rbtools/commands/post.py
    rbtools/utils/review_request.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/match_score.py
    rbtools/commands/post.py
    rbtools/utils/review_request.py