Add test to verify that static files exist

Review Request #8603 — Created Jan. 7, 2017 and submitted

Information

Review Board
master
56e62a1...

Reviewers

The test verifies that all files referenced in staticbundles.py exists.

Remove reference to:
* rb/js/admin/models/supportContractModel.js: reference, but no file, added in
6a857664
* rb/js/views/fileAttachmentCommentBlockView.js: reference, but no file, added
in 7b3a4b6d
* rb/js/diffviewer.js: file removed in 05ba1ae3
* rb/js/reviews.js: file removed in d7cdfa6d

Creating test database for alias 'default'...
#888 Testing that all static javascript files exist ... ok
#889 Testing that all static stylesheet files exist ... ok

----------------------------------------------------------------------
Ran 2 tests in 1.373s

OK
Description From Last Updated

Add a file level docstring indicating what this file is. The first import should be from __future__ import unicode_literals.

brenniebrennie

Missing a class docstring.

brenniebrennie

Missing method docstring. Private method names in testcases should be prefixed with an underscore.

brenniebrennie

Missing method docstring.

brenniebrennie

Missing method docstring.

brenniebrennie

There should be a blank line between these; imports go into 3 groups: stdlib, "third party" (including djblets), and "this …

daviddavid

Blank line between these two.

daviddavid

Nicer formatting might be: static_path = os.path.join('reviewboard', 'static', path) if not os.path.exists(static_path): missing.add(path)

daviddavid

Our testcase docstrings are all of the format "Testing ...". They also shouldn't contain the trailing period, since the test …

daviddavid

Same here.

daviddavid

Blank line between these two, please.

daviddavid
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/tests.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/tests.py
    
    
  2. 
      
erijo
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/tests.py
        reviewboard/staticbundles.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/tests.py
        reviewboard/staticbundles.py
    
    
  2. 
      
brennie
  1. 
      
  2. reviewboard/tests.py (Diff revision 2)
     
     

    Add a file level docstring indicating what this file is.

    The first import should be from __future__ import unicode_literals.

  3. reviewboard/tests.py (Diff revision 2)
     
     

    Missing a class docstring.

  4. reviewboard/tests.py (Diff revision 2)
     
     

    Missing method docstring.

    Private method names in testcases should be prefixed with an underscore.

  5. reviewboard/tests.py (Diff revision 2)
     
     

    Missing method docstring.

  6. reviewboard/tests.py (Diff revision 2)
     
     

    Missing method docstring.

  7. 
      
erijo
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/tests.py
        reviewboard/staticbundles.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/tests.py
        reviewboard/staticbundles.py
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/tests.py (Diff revision 3)
     
     
     

    There should be a blank line between these; imports go into 3 groups: stdlib, "third party" (including djblets), and "this module".

  3. reviewboard/tests.py (Diff revision 3)
     
     
     

    Blank line between these two.

  4. reviewboard/tests.py (Diff revision 3)
     
     
     
     

    Nicer formatting might be:

    static_path = os.path.join('reviewboard', 'static', path)
    
    if not os.path.exists(static_path):
        missing.add(path)
    
  5. reviewboard/tests.py (Diff revision 3)
     
     

    Our testcase docstrings are all of the format "Testing ...". They also shouldn't contain the trailing period, since the test runner adds an ellipsis.

    Proper grammar should also be "all static javascript files exist"

  6. reviewboard/tests.py (Diff revision 3)
     
     

    Same here.

  7. 
      
erijo
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/tests.py
        reviewboard/staticbundles.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/tests.py
        reviewboard/staticbundles.py
    
    
  2. 
      
david
  1. Just one trivial thing left.

  2. reviewboard/tests.py (Diff revision 4)
     
     
     

    Blank line between these two, please.

  3. 
      
erijo
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/tests.py
        reviewboard/staticbundles.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/tests.py
        reviewboard/staticbundles.py
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
david
  1. I'm going to land this with one tiny last-minute change that I noticed. Thanks so much for this!

  2. 
      
erijo
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (eece297)
Loading...