Summary

Support on-the-fly search indexing

Review Request #8601 — Created Jan. 5, 2017 and submitted June 12, 2017, 3:43 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

~~8600~~

Reviewers

Groups

reviewboard

People

Description

On-the-fly search indexing is now supported for the Elasticsearch search
backend. When the option is enabled (from the search settings
administration form), the search index will be updated whenever review
requests are updated or deleted.

Additionally, the default value of the Whoosh search index has been
renamed to "search-index", which was the original default; it was
accidentally changed to "search_index" in a previous change.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
You probably didn't mean to include cat.jpg.	chipx86	March 7, 2017, 1:39 p.m.
'elasticsearch' imported but unused	reviewbot	Jan. 6, 2017, 4:59 p.m.
'elasticsearch' imported but unused	reviewbot	Jan. 9, 2017, 1:58 p.m.
One blank line.	chipx86	Jan. 9, 2017, 2:42 p.m.
Each item should be sentence casing, and no "; and" or any other delimiter between items. This is the standard …	chipx86	Jan. 9, 2017, 2:42 p.m.
We also need to index Users when created/modified/deleted or when group membership changes (see accounts/search_indexes.py).	chipx86	Jan. 9, 2017, 2:54 p.m.
Missing docstring.	chipx86	Jan. 9, 2017, 2:55 p.m.
Missing docstring.	chipx86	Jan. 9, 2017, 2:55 p.m.
**kwargs	chipx86	Jan. 9, 2017, 2:55 p.m.
Can we put review_request in the function argument list instead? By the way, if this function's going to be specific …	chipx86	Jan. 9, 2017, 2:55 p.m.
**kwargs	chipx86	Jan. 9, 2017, 2:55 p.m.
Alphabetical order.	chipx86	Jan. 9, 2017, 3:14 p.m.
As discussed in Slack, we're going to want to allow this for Whoosh. It may not be great for large …	chipx86	Jan. 9, 2017, 3:14 p.m.
Probably better as self.assertIsInstance(...)	chipx86	Jan. 9, 2017, 3:14 p.m.
assertIsInstance	chipx86	Jan. 9, 2017, 3:14 p.m.
'django_reset' imported but unused	reviewbot	Jan. 9, 2017, 1:58 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Jan. 9, 2017, 1:58 p.m.
"whe" -> "when"	chipx86	March 7, 2017, 12:50 p.m.
Two blank lines.	chipx86	March 7, 2017, 1:27 p.m.
I don't think the way this is all working is thread-safe. If multiple threads are all going through the signal …	chipx86	March 7, 2017, 1:27 p.m.
Can we move this below, so it's closer to where we connect it?	chipx86	March 7, 2017, 1:27 p.m.
Just wondering, but is there any chance that this can negatively impact consumers today? Or does this situation emit a …	chipx86	March 7, 2017, 1:27 p.m.
:py:attr: here?	chipx86	March 7, 2017, 1:27 p.m.
"wasn't instead" ?	chipx86	March 7, 2017, 1:26 p.m.
Col: 80 E501 line too long (101 > 79 characters)	reviewbot	Jan. 9, 2017, 6:36 p.m.
Blank line between these.	chipx86	March 7, 2017, 1:26 p.m.
Only one "g" in "arguments" :)	chipx86	March 7, 2017, 1:24 p.m.
This looks like a Shortest Middle Snake comment.	chipx86	March 7, 2017, 1:24 p.m.
Since it's the search indexing specifically that needs this, I'd prefer not to put this variable in the signal emission. …	chipx86	March 7, 2017, 1:23 p.m.
'elasticsearch' imported but unused	reviewbot	Jan. 9, 2017, 6:36 p.m.
"on-the-fly indexing", I think.	chipx86	March 7, 2017, 1:23 p.m.
Can be one statement.	chipx86	March 7, 2017, 1:23 p.m.
'django_reset' imported but unused	reviewbot	Jan. 9, 2017, 6:36 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Jan. 9, 2017, 6:36 p.m.
Do we need both? Did the name change?	chipx86	March 14, 2017, 3:14 p.m.
'elasticsearch' imported but unused	reviewbot	March 7, 2017, 1:53 p.m.
Just to help future expandability, can we put Group into a list like we do with save/delete signals?	chipx86	March 14, 2017, 3:14 p.m.
Col: 80 E501 line too long (86 > 79 characters)	reviewbot	March 7, 2017, 1:46 p.m.
You can wrap before the < to satisfy pyflakes.	chipx86	March 14, 2017, 3:09 p.m.
Alignment is off by one.	chipx86	March 14, 2017, 3:09 p.m.
Wasn't what?	chipx86	March 14, 2017, 3:09 p.m.
Col: 80 E501 line too long (105 > 79 characters)	reviewbot	March 7, 2017, 1:46 p.m.
Lists can't be indented, or they'll render incorrectly. The * must be aligned with the preceding paragraph.	chipx86	March 14, 2017, 3:09 p.m.
Looks like some spaces snuck in here.	chipx86	March 14, 2017, 3:09 p.m.
There's an extra space after pk_set.	chipx86	March 14, 2017, 3:09 p.m.
'django_reset' imported but unused	reviewbot	March 7, 2017, 1:46 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 7, 2017, 1:46 p.m.
'elasticsearch' imported but unused	reviewbot	March 14, 2017, 3:22 p.m.
Col: 80 E501 line too long (105 > 79 characters)	reviewbot	March 14, 2017, 3:22 p.m.
Col: 1 W391 blank line at end of file	reviewbot	March 14, 2017, 3:22 p.m.
'django_reset' imported but unused	reviewbot	March 14, 2017, 3:22 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 14, 2017, 3:22 p.m.
'elasticsearch' imported but unused	reviewbot	March 14, 2017, 3:23 p.m.
Why this change?	chipx86	April 24, 2017, 6:23 p.m.
"on-the-fly"	chipx86	April 24, 2017, 6:25 p.m.
Col: 80 E501 line too long (105 > 79 characters)	reviewbot	March 14, 2017, 3:23 p.m.
reviewboard.reviews.models.group.Group, here and anywhere else.	chipx86	April 24, 2017, 6:25 p.m.
'django_reset' imported but unused	reviewbot	March 14, 2017, 3:23 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 14, 2017, 3:23 p.m.
I would say "... for large or multi-server installs."	chipx86	June 12, 2017, 3:37 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/search/search_backends/base.py
    reviewboard/search/signal_processor.py
    reviewboard/search/search_backends/registry.py
    reviewboard/search/search_backends/elasticsearch.py

Ignored Files:
    reviewboard/htdocs/media/cat.jpg



Tool: Pyflakes
Processed Files:
    reviewboard/search/search_backends/base.py
    reviewboard/search/signal_processor.py
    reviewboard/search/search_backends/registry.py
    reviewboard/search/search_backends/elasticsearch.py

Ignored Files:
    reviewboard/htdocs/media/cat.jpg

reviewboard/search/search_backends/elasticsearch.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'elasticsearch' imported but unused
```

Testing Done:

~		Updated & deleted review requests and saw the resulting changes in the
	~	Ran unit tests.
-		search index when the option was enabled.

Diff:

Revision 2 (+169 -3)

Show changes

	reviewboard/settings.py
	reviewboard/htdocs/media/cat.jpg
	reviewboard/search/signal_processor.py
	reviewboard/search/tests.py
	reviewboard/search/search_backends/base.py
	reviewboard/search/search_backends/elasticsearch.py
	reviewboard/search/search_backends/registry.py

Tool: Pyflakes
Processed Files:
    reviewboard/settings.py
    reviewboard/search/search_backends/registry.py
    reviewboard/search/tests.py
    reviewboard/search/signal_processor.py
    reviewboard/search/search_backends/base.py
    reviewboard/search/search_backends/elasticsearch.py

Ignored Files:
    reviewboard/htdocs/media/cat.jpg



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/settings.py
    reviewboard/search/search_backends/registry.py
    reviewboard/search/tests.py
    reviewboard/search/signal_processor.py
    reviewboard/search/search_backends/base.py
    reviewboard/search/search_backends/elasticsearch.py

Ignored Files:
    reviewboard/htdocs/media/cat.jpg

reviewboard/search/search_backends/elasticsearch.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'elasticsearch' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

reviewboard/search/search_backends/registry.py (Diff revision 2)
The issue has been resolved. Show all issues
```
One blank line.
```

reviewboard/search/signal_processor.py (Diff revision 2)

The issue has been resolved. Show all issues

Each item should be sentence casing, and no "; and" or any other delimiter between items. This is the standard form for lists in documentation.

reviewboard/search/signal_processor.py (Diff revision 2)

The issue has been resolved. Show all issues

We also need to index Users when created/modified/deleted or when group membership changes (see accounts/search_indexes.py).

reviewboard/search/signal_processor.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing docstring.
```
reviewboard/search/signal_processor.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing docstring.
```
reviewboard/search/signal_processor.py (Diff revision 2)
The issue has been resolved. Show all issues
```
**kwargs
```

reviewboard/search/signal_processor.py (Diff revision 2)

The issue has been resolved. Show all issues

Can we put review_request in the function argument list instead?
By the way, if this function's going to be specific to review requests, we should rename the function and update how it's connected.

reviewboard/search/signal_processor.py (Diff revision 2)
The issue has been resolved. Show all issues
```
**kwargs
```
reviewboard/search/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Alphabetical order.
```

reviewboard/search/tests.py (Diff revision 2)

The issue has been resolved. Show all issues

As discussed in Slack, we're going to want to allow this for Whoosh. It may not be great for large deployments, but smaller ones should definitely be able to start out with on-the-fly indexing.

reviewboard/search/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Probably better as self.assertIsInstance(...)
```
reviewboard/search/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
assertIsInstance
```

Change Summary:


Users are now indexed on the fly.
M2M fields for users are now indexed correctly.
The on the fly indexing option is now a generic search option and is off by default (because Whoosh is the default engine). A note is displayed below the option indicating it is not intended for large installs when using the Whoosh engine.

Diff:

Revision 3 (+355 -8)

Show changes

	reviewboard/settings.py
	reviewboard/admin/forms.py
	reviewboard/admin/siteconfig.py
	reviewboard/htdocs/media/cat.jpg
	reviewboard/reviews/__init__.py
	reviewboard/reviews/signals.py
	reviewboard/reviews/models/review_request.py
	reviewboard/search/signal_processor.py
	4 more

Tool: Pyflakes
Processed Files:
    reviewboard/admin/siteconfig.py
    reviewboard/admin/forms.py
    reviewboard/settings.py
    reviewboard/search/search_backends/registry.py
    reviewboard/search/tests.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/__init__.py
    reviewboard/search/signal_processor.py
    reviewboard/reviews/signals.py
    reviewboard/search/search_backends/elasticsearch.py

Ignored Files:
    reviewboard/templates/admin/search_settings.html
    reviewboard/htdocs/media/cat.jpg



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/siteconfig.py
    reviewboard/admin/forms.py
    reviewboard/settings.py
    reviewboard/search/search_backends/registry.py
    reviewboard/search/tests.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/__init__.py
    reviewboard/search/signal_processor.py
    reviewboard/reviews/signals.py
    reviewboard/search/search_backends/elasticsearch.py

Ignored Files:
    reviewboard/templates/admin/search_settings.html
    reviewboard/htdocs/media/cat.jpg

reviewboard/reviews/__init__.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (101 > 79 characters)
```
reviewboard/search/search_backends/elasticsearch.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'elasticsearch' imported but unused
```
reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Got some thoughts on the signal-related changes. The rest are mostly trivial changes.

The issue has been resolved. Show all issues

You probably didn't mean to include cat.jpg.

brennie March 7, 2017, 1:39 p.m.
```
cat.jpg is integral to this feature.
```

reviewboard/admin/forms.py (Diff revision 3)
The issue has been resolved. Show all issues
```
"whe" -> "when"
```
reviewboard/reviews/__init__.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Two blank lines.
```

reviewboard/reviews/__init__.py (Diff revision 3)

The issue has been resolved. Show all issues

I don't think the way this is all working is thread-safe. If multiple threads are all going through the signal logic below with the same PK as the key, they're going to stomp over each other. You'll need a threading.local() for all this.

Should also help prevent the same level of leakage that could occur if there's any kind of error in-between the pre_clear/post_clear signals.

reviewboard/reviews/__init__.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Can we move this below, so it's closer to where we connect it?
```

reviewboard/reviews/__init__.py (Diff revision 3)

The issue has been resolved. Show all issues

Just wondering, but is there any chance that this can negatively impact consumers today? Or does this situation emit a signal that's otherwise never sent?
My concern is that this code, which is really intended for the search index specifically, could end up with side-effects that we're not anticipating. It sounds like it's inconsistent with how signals normally work for these relations, which potentially could trip someone up down the road?
I wonder if instead of having all this be general, we could make this really about the search index. That is, instead of having this be global here, we have this live in the search indexing code and have the results be function calls into the indexing code instead of signal emissions.

reviewboard/reviews/__init__.py (Diff revision 3)
The issue has been resolved. Show all issues
```
:py:attr: here?
```
reviewboard/reviews/__init__.py (Diff revision 3)
The issue has been resolved. Show all issues
```
"wasn't instead" ?
```
reviewboard/reviews/__init__.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/reviews/__init__.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Only one "g" in "arguments" :)
```
reviewboard/reviews/__init__.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This looks like a Shortest Middle Snake comment.
```

reviewboard/reviews/signals.py (Diff revision 3)

The issue has been resolved. Show all issues

Since it's the search indexing specifically that needs this, I'd prefer not to put this variable in the signal emission. It's a bit confusing and redundant, and sets a precedent for future signals we have to listen to (in our app and maybe others down the road). Instead, the search indexing code should be able to handle the different keyword names.
What you could do in the indexing signal connection code is something like:

from functools import partial

...

save_signals = [
    (ReviewRequest, review_request_published, 'review_request'),
    (User, post_save, 'instance'),
    (User, m2m_changed, 'instance'),
]

...

save_handler = partial(self.check_handle_save, instance_kwarg=

for cls, signal, instance_kwarg in self.save_signals:
    signal.connect(
        partial(self.check_handle_save, instance_kwarg=instance_kwarg),
        sender=cls)

...

def check_handle_save(self, instance_kwarg, **kwargs):
    instance = kwargs[instance_kwarg]
    ...


(Maybe weak=False will have to be passed to connect. I'm not sure.)

reviewboard/search/search_backends/registry.py (Diff revision 3)
The issue has been resolved. Show all issues
```
"on-the-fly indexing", I think.
```
reviewboard/search/search_backends/registry.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Can be one statement.
```

Diff:

Revision 4 (+352 -7)

Show changes

	.gitignore
	reviewboard/settings.py
	reviewboard/admin/forms.py
	reviewboard/admin/siteconfig.py
	reviewboard/reviews/signals.py
	reviewboard/search/signal_processor.py
	reviewboard/search/tests.py
	reviewboard/search/search_backends/elasticsearch.py
	2 more

Tool: Pyflakes
Processed Files:
    reviewboard/admin/siteconfig.py
    reviewboard/admin/forms.py
    reviewboard/settings.py
    reviewboard/search/search_backends/registry.py
    reviewboard/search/tests.py
    reviewboard/search/signal_processor.py
    reviewboard/reviews/signals.py
    reviewboard/search/search_backends/elasticsearch.py

Ignored Files:
    reviewboard/templates/admin/search_settings.html
    .gitignore



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/siteconfig.py
    reviewboard/admin/forms.py
    reviewboard/settings.py
    reviewboard/search/search_backends/registry.py
    reviewboard/search/tests.py
    reviewboard/search/signal_processor.py
    reviewboard/reviews/signals.py
    reviewboard/search/search_backends/elasticsearch.py

Ignored Files:
    reviewboard/templates/admin/search_settings.html
    .gitignore

reviewboard/search/search_backends/elasticsearch.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'elasticsearch' imported but unused
```
reviewboard/search/signal_processor.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (86 > 79 characters)
```
reviewboard/search/signal_processor.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (105 > 79 characters)
```
reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Looks great! All my comments here are very minor things. (Mostly typos/ReST errors.)

.gitignore (Diff revision 4)

The issue has been resolved. Show all issues

Do we need both? Did the name change?

brennie March 14, 2017, 3:18 p.m.

I accidentally changed the default in a previous patch. I've undone that change now.

reviewboard/search/signal_processor.py (Diff revision 4)

The issue has been dropped. Show all issues

Just to help future expandability, can we put Group into a list like we do with save/delete signals?

reviewboard/search/signal_processor.py (Diff revision 4)
The issue has been resolved. Show all issues
```
You can wrap before the < to satisfy pyflakes.
```
reviewboard/search/signal_processor.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Alignment is off by one.
```
reviewboard/search/signal_processor.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Wasn't what?
```

reviewboard/search/signal_processor.py (Diff revision 4)

The issue has been resolved. Show all issues

Lists can't be indented, or they'll render incorrectly. The * must be aligned with the preceding paragraph.

reviewboard/search/signal_processor.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Looks like some spaces snuck in here.
```
reviewboard/search/signal_processor.py (Diff revision 4)
The issue has been resolved. Show all issues
```
There's an extra space after pk_set.
```

Description:

		On-the-fly search indexing is now supported for the Elasticsearch search
		backend. When the option is enabled (from the search settings
		administration form), the search index will be updated whenever review
		requests are updated or deleted.
	+
	+	Additionally, the default value of the Whoosh search index has been
	+	renamed to "search-index", which was the original default; it was
	+	accidentally changed to "search_index" in a previous change.

Diff:

Revision 5 (+360 -8)

Show changes

	reviewboard/settings.py
	reviewboard/admin/forms.py
	reviewboard/admin/siteconfig.py
	reviewboard/reviews/signals.py
	reviewboard/search/signal_processor.py
	reviewboard/search/tests.py
	reviewboard/search/search_backends/elasticsearch.py
	reviewboard/search/search_backends/registry.py
	2 more

Tool: Pyflakes
Processed Files:
    reviewboard/admin/siteconfig.py
    reviewboard/admin/forms.py
    reviewboard/settings.py
    reviewboard/search/search_backends/registry.py
    reviewboard/search/search_backends/whoosh.py
    reviewboard/search/tests.py
    reviewboard/search/signal_processor.py
    reviewboard/reviews/signals.py
    reviewboard/search/search_backends/elasticsearch.py

Ignored Files:
    reviewboard/templates/admin/search_settings.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/siteconfig.py
    reviewboard/admin/forms.py
    reviewboard/settings.py
    reviewboard/search/search_backends/registry.py
    reviewboard/search/search_backends/whoosh.py
    reviewboard/search/tests.py
    reviewboard/search/signal_processor.py
    reviewboard/reviews/signals.py
    reviewboard/search/search_backends/elasticsearch.py

Ignored Files:
    reviewboard/templates/admin/search_settings.html

reviewboard/search/search_backends/elasticsearch.py (Diff revision 5)
The issue has been resolved. Show all issues
```
 'elasticsearch' imported but unused
```
reviewboard/search/signal_processor.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (105 > 79 characters)
```
reviewboard/search/signal_processor.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```
reviewboard/settings.py (Diff revision 5)
The issue has been resolved. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 5)
The issue has been resolved. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Diff:

Revision 6 (+359 -8)

Show changes

	reviewboard/settings.py
	reviewboard/admin/forms.py
	reviewboard/admin/siteconfig.py
	reviewboard/reviews/signals.py
	reviewboard/search/signal_processor.py
	reviewboard/search/tests.py
	reviewboard/search/search_backends/elasticsearch.py
	reviewboard/search/search_backends/registry.py
	2 more

Tool: Pyflakes
Processed Files:
    reviewboard/admin/siteconfig.py
    reviewboard/admin/forms.py
    reviewboard/settings.py
    reviewboard/search/search_backends/registry.py
    reviewboard/search/search_backends/whoosh.py
    reviewboard/search/tests.py
    reviewboard/search/signal_processor.py
    reviewboard/reviews/signals.py
    reviewboard/search/search_backends/elasticsearch.py

Ignored Files:
    reviewboard/templates/admin/search_settings.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/siteconfig.py
    reviewboard/admin/forms.py
    reviewboard/settings.py
    reviewboard/search/search_backends/registry.py
    reviewboard/search/search_backends/whoosh.py
    reviewboard/search/tests.py
    reviewboard/search/signal_processor.py
    reviewboard/reviews/signals.py
    reviewboard/search/search_backends/elasticsearch.py

Ignored Files:
    reviewboard/templates/admin/search_settings.html

reviewboard/search/search_backends/elasticsearch.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'elasticsearch' imported but unused
```
reviewboard/search/signal_processor.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (105 > 79 characters)
```
reviewboard/settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

reviewboard/search/search_backends/whoosh.py (Diff revision 6)

The issue has been dropped. Show all issues

Why this change?

brennie April 24, 2017, 6:24 p.m.

It originally was search-index, but when the patch for search backends went it in it changed to search_index. This moves us back to the original.

reviewboard/search/signal_processor.py (Diff revision 6)
The issue has been resolved. Show all issues
```
"on-the-fly"
```
reviewboard/search/signal_processor.py (Diff revision 6)
The issue has been resolved. Show all issues
```
reviewboard.reviews.models.group.Group, here and anywhere else.
```

Change Summary:

Addressed Christian's issues.

Diff:

Revision 7 (+359 -8)

Show changes

	reviewboard/settings.py
	reviewboard/admin/forms.py
	reviewboard/admin/siteconfig.py
	reviewboard/reviews/signals.py
	reviewboard/search/signal_processor.py
	reviewboard/search/tests.py
	reviewboard/search/search_backends/elasticsearch.py
	reviewboard/search/search_backends/registry.py
	2 more

Checks run (2 succeeded, 1 failed with error)

JSHint passed.

PEP8 Style Checker internal error.

Pyflakes passed.

Ship it!

reviewboard/admin/forms.py (Diff revision 7)
The issue has been resolved. Show all issues
```
I would say "... for large or multi-server installs."
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (7de3a90)