• 
      

    Allow search to be disabled

    Review Request #8600 — Created Jan. 5, 2017 and submitted

    Information

    Review Board
    release-3.0.x
    40a8bcf...

    Reviewers

    Previously, we always attempted to save the configuration form for the
    currently selected search backend, even when we were disabling search.
    This lead a 500 error and search not being able to be disabled (as we
    were only checking the validity of the form when search was enabled).
    Now we only save the sub-form configuration when search is enabled,
    which lets search be disabled successfully.

    I was able to disable search with this patch applied. Without it I
    could not.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/admin/forms.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/admin/forms.py
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    brennie
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (c133f3a)