Autocomplete group names that contains key

Review Request #8585 - Created Jan. 1, 2017 and discarded

Erik Johansson
Review Board
master
reviewboard
When you have a lot of groups that share a common prefix (e.g. Team_...) it is
useful to be able to autocomplete group names without having to type the common
prefix.

Add a webapi feature that needs to be enabled for the extended search to be
enabled. This to avoid problems on installation where enabling contains
searches may affect performance too much.

Add a new parameter `contains` to /api/groups/ that, when set, changes the
filtering from "istartswith" to "icontains" and thus matches the key anywhere
in the name (or display name if displayname=1).

Change the review request editor view to set this contains=1 in the request and
matchContains option on the autocomplete widget to make it all work.

New unit tests passes.

Manual tested that it is possible to autocomplete names without typing the prefix.

Documentation looks ok.

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/testing/testcase.py
        reviewboard/webapi/resources/review_group.py
        reviewboard/webapi/tests/test_review_group.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/testing/testcase.py
        reviewboard/webapi/resources/review_group.py
        reviewboard/webapi/tests/test_review_group.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
  2. 
      
Erik Johansson
Erik Johansson
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/testing/testcase.py
        reviewboard/webapi/resources/review_group.py
        reviewboard/webapi/tests/base.py
        reviewboard/webapi/tests/test_review_group.py
        reviewboard/webapi/features.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/testing/testcase.py
        reviewboard/webapi/resources/review_group.py
        reviewboard/webapi/tests/base.py
        reviewboard/webapi/tests/test_review_group.py
        reviewboard/webapi/features.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
  2. Col: 20
     E127 continuation line over-indented for visual indent
    
  3. 
      
Erik Johansson
Review Bot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/testing/testcase.py
        reviewboard/webapi/resources/review_group.py
        reviewboard/webapi/tests/base.py
        reviewboard/webapi/tests/test_review_group.py
        reviewboard/webapi/features.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/testing/testcase.py
        reviewboard/webapi/resources/review_group.py
        reviewboard/webapi/tests/base.py
        reviewboard/webapi/tests/test_review_group.py
        reviewboard/webapi/features.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
  2. 
      
Erik Johansson
Review request changed

Status: Discarded

Loading...