Integrate artwork.
Review Request #8584 — Created Dec. 30, 2016 and submitted
This change brings in the artwork for Review Bot, which is used in two places:
the integration list, and the user avatar.
- Verified that I could see the logo in the integrations list.
- Created a new user for Review Bot and saw that the correct avatar was
assigned.
-
-
extension/reviewbotext/views.py (Diff revision 1) How about fetching the username using
request.POST.get('reviewbot_user')and then deciding things off of that? Right now we're doing 3 lookups.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+29 -2) |
-
Tool: Pyflakes Processed Files: extension/reviewbotext/views.py extension/reviewbotext/integration.py Ignored Files: extension/reviewbotext/static/images/reviewbot.png extension/reviewbotext/static/images/reviewbot@2x.png Tool: PEP8 Style Checker Processed Files: extension/reviewbotext/views.py extension/reviewbotext/integration.py Ignored Files: extension/reviewbotext/static/images/reviewbot.png extension/reviewbotext/static/images/reviewbot@2x.png
-
-
extension/reviewbotext/views.py (Diff revisions 1 - 2) I don't think the
int()is needed. Django, iirc, does the right thing, converting to an int as needed (with its own type checking). The old code didn't have it.
Tool: Pyflakes Processed Files: extension/reviewbotext/views.py extension/reviewbotext/integration.py Ignored Files: extension/reviewbotext/static/images/reviewbot.png extension/reviewbotext/static/images/reviewbot@2x.png Tool: PEP8 Style Checker Processed Files: extension/reviewbotext/views.py extension/reviewbotext/integration.py Ignored Files: extension/reviewbotext/static/images/reviewbot.png extension/reviewbotext/static/images/reviewbot@2x.png