Fix problems with review request draft unit tests.

Review Request #8579 — Created Dec. 24, 2016 and submitted

Information

Review Board
release-3.0.x
684d986...

Reviewers

With some recent changes to fix a bug whereby creating post-commit review
requests wasn't creating the draft object, a couple unit tests broke. The
problem here was that the draft's repository object wasn't the same as the
one that the review request is initialized with (because it fetches it
separately), so the spies weren't overriding the right methods.

I've fixed these up, and also cleaned up the code to initialize the Commit
objects with the intended message instead of assigning it after creation.

Ran unit tests.

Description From Last Updated

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/tests/test_review_request_draft.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/tests/test_review_request_draft.py
    
    
  2. Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  3. Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  4. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/tests/test_review_request_draft.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/tests/test_review_request_draft.py
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (15b57b8)
Loading...