Summary

Support e-mail address logins in the API

Review Request #8578 — Created Dec. 16, 2016 and submitted Jan. 4, 2017, 12:06 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

fa3ea10...

Reviewers

Groups

reviewboard

People

Description

The API now supports logging in with an e-mail address just like the
normal login view. A new WebAPI auth backend has been added that
translates supplied e-mail addresses to usernames so that they can be
used in the standard auth backend.

Testing Done

Authenticated with an e-mail address via the API.

Issues

Description	From	Last Updated
'django_reset' imported but unused	reviewbot	Dec. 16, 2016, 2:06 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Dec. 16, 2016, 2:06 p.m.
'PIPELINE_JS' imported but unused	reviewbot	Dec. 16, 2016, 2:06 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	Dec. 16, 2016, 2:06 p.m.
I think the official capitalization is "HTTP Basic authentication". It's not an acronym.	david	Dec. 23, 2016, 11:40 a.m.
"@" is a valid character in the User.username field. We should try to look up User by username, and if …	david	Dec. 23, 2016, 11:40 a.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/auth_backends.py
    reviewboard/settings.py



Tool: Pyflakes
Processed Files:
    reviewboard/webapi/auth_backends.py
    reviewboard/settings.py

reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```

reviewboard/webapi/auth_backends.py (Diff revision 1)

The issue has been resolved. Show all issues

I think the official capitalization is "HTTP Basic authentication". It's not an acronym.

reviewboard/webapi/auth_backends.py (Diff revision 1)

The issue has been resolved. Show all issues

"@" is a valid character in the User.username field. We should try to look up User by username, and if that doesn't exist, then look up by e-mail address.

Diff:

Revision 2 (+44 -1)

Show changes

	reviewboard/settings.py
	reviewboard/webapi/auth_backends.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/auth_backends.py
    reviewboard/settings.py

Testing Done:: ~
Authenticated with a username via the API.
~
Authenticated with an e-mail address via the API.

Ship it!

```
You can add bug 4448.
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (bf7bd55)

~		Authenticated with a username via the API.
	~	Authenticated with an e-mail address via the API.