Review Bot
David Trowbridge
-
reviewboard/settings.py (Diff revision 1) 'django_reset' imported but unused
-
reviewboard/settings.py (Diff revision 1) 'from settings_local import *' used; unable to detect undefined names
-
reviewboard/settings.py (Diff revision 1) 'PIPELINE_JS' imported but unused
-
reviewboard/settings.py (Diff revision 1) 'PIPELINE_CSS' imported but unused
Support e-mail address logins in the API
Review Request #8578 - Created Dec. 16, 2016 and submitted
| Information | |
|---|---|
| Barret Rennie | |
| Review Board | |
| release-2.5.x | |
| fa3ea10... | |
| Reviewers | |
| reviewboard | |
The API now supports logging in with an e-mail address just like the
normal login view. A new WebAPI auth backend has been added that
translates supplied e-mail addresses to usernames so that they can be
used in the standard auth backend.
Authenticated with an e-mail address via the API.
-
-
reviewboard/webapi/auth_backends.py (Diff revision 1) I think the official capitalization is "HTTP Basic authentication". It's not an acronym.
-
reviewboard/webapi/auth_backends.py (Diff revision 1) "@" is a valid character in the
User.usernamefield. We should try to look upUserby username, and if that doesn't exist, then look up by e-mail address.
-
Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/auth_backends.py reviewboard/settings.py
Review request changed
Testing Done: |
|
|---|
-
You can add bug 4448.
Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/auth_backends.py reviewboard/settings.py Tool: Pyflakes Processed Files: reviewboard/webapi/auth_backends.py reviewboard/settings.py