Support renamed files from GitHub in post-commit UI

Review Request #8577 — Created Dec. 16, 2016 and submitted

Information

Review Board
release-2.0.x
66a109f...

Reviewers

The GitHub client did not support generating the diff for a file renamed
in a change that was retrieved via the post-commit review UI. This has
been corrected. Additionally, the code was somewhat cleaned up to not
shadow the file global. The unit test for get_change has been
updated to add a case for renamed files.

Used the post-commit UI to create a new review request that contained a
renamed file. It worked as expected.

Description From Last Updated

Can we get a unit test for this?

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/github.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/github.py
    
    
  2. 
      
brennie
david
  1. 
      
  2. Can we get a unit test for this?

  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/github.py
        reviewboard/hostingsvcs/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/github.py
        reviewboard/hostingsvcs/tests.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (2f32cd0)
Loading...