Summary

Support renamed files from GitHub in post-commit UI

Review Request #8577 — Created Dec. 16, 2016 and submitted Dec. 16, 2016, 2:07 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

66a109f...

Reviewers

Groups

reviewboard

People

Description

The GitHub client did not support generating the diff for a file renamed
in a change that was retrieved via the post-commit review UI. This has
been corrected. Additionally, the code was somewhat cleaned up to not
shadow the file global. The unit test for get_change has been
updated to add a case for renamed files.

Testing Done

Used the post-commit UI to create a new review request that contained a
renamed file. It worked as expected.

Issues

Description	From	Last Updated
Can we get a unit test for this?	david	Dec. 16, 2016, 11 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/github.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/github.py

Description:: The GitHub client did not support generating the diff for a file renamed
in a change that was retrieved via the post-commit review UI. This has
~ been corrected.
~ been corrected. Additionally, the code was somewhat cleaned up to not
+ shadow the file global.

The issue has been resolved. Show all issues
```
Can we get a unit test for this?
```

Description:

		The GitHub client did not support generating the diff for a file renamed
		in a change that was retrieved via the post-commit review UI. This has
		been corrected. Additionally, the code was somewhat cleaned up to not
~		shadow the `file` global.
	~	shadow the `file` global. The unit test for `get_change` has been
	+	updated to add a case for renamed files.

Commit:

5c5db61715fc010b7e90c9308d98ec91a278ae7e

66a109fddb6b37f8d907d47718c734d1f13405a4

Diff:

Revision 2 (+35 -10)

Show changes

	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/github.py
    reviewboard/hostingsvcs/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/github.py
    reviewboard/hostingsvcs/tests.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (2f32cd0)

		The GitHub client did not support generating the diff for a file renamed
		in a change that was retrieved via the post-commit review UI. This has
~		been corrected.
	~	been corrected. Additionally, the code was somewhat cleaned up to not
	+	shadow the `file` global.