Summary:

Add a widget to choose between self-hosted and gitlab.com-hosted GitLab

Review Request #8576 — Created Dec. 15, 2016 and submitted Jan. 4, 2017, 12:06 p.m.

Information
Owner:	brennie
Repository:	Review Board
Branch:	release-2.5.x
Bugs:
Depends On:
Commit:	df62b37...
Reviewers
Groups:	reviewboard
People:

Description

GitLab repository accounts now have a special widget to allow the use to
choose between gitlab.com-hosted and self-hosted GitLab instances. In
addition, the field is now validated to ensure that it has a valid URL
scheme. Previously if the scheme was omitted a repository not found
error would occur, even for otherwise valid URLs (e.g., gitlab.com vs
https://gitlab.com).

Testing Done


Added a gitlab.com repository: it worked as expected.
Added a repository with an invalid URL: the new error message was

  provided instead of the old one.

Files

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/gitlab.py

Ignored Files:
    reviewboard/templates/hostingsvcs/gitlab/url_widget.html
    reviewboard/static/rb/css/pages/admin.less



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/gitlab.py

Ignored Files:
    reviewboard/templates/hostingsvcs/gitlab/url_widget.html
    reviewboard/static/rb/css/pages/admin.less

Ship it!

```
Nice change.
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (19687c1)