Add a widget to choose between self-hosted and gitlab.com-hosted GitLab

Review Request #8576 - Created Dec. 15, 2016 and submitted

Barret Rennie
Review Board
release-2.5.x
df62b37...
reviewboard

GitLab repository accounts now have a special widget to allow the use to
choose between gitlab.com-hosted and self-hosted GitLab instances. In
addition, the field is now validated to ensure that it has a valid URL
scheme. Previously if the scheme was omitted a repository not found
error would occur, even for otherwise valid URLs (e.g., gitlab.com vs
https://gitlab.com).

  • Added a gitlab.com repository: it worked as expected.
  • Added a repository with an invalid URL: the new error message was
    provided instead of the old one.
Loading file attachments...

Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/gitlab.py
    
    Ignored Files:
        reviewboard/templates/hostingsvcs/gitlab/url_widget.html
        reviewboard/static/rb/css/pages/admin.less
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/gitlab.py
    
    Ignored Files:
        reviewboard/templates/hostingsvcs/gitlab/url_widget.html
        reviewboard/static/rb/css/pages/admin.less
    
    
  2. 
      
Christian Hammond
  1. Nice change.

  2. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (19687c1)
Loading...