Summary

Fix loading of serialized comments for the image review UI.

Review Request #8573 — Created Dec. 14, 2016 and submitted Dec. 16, 2016, 12:01 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

d4f17f9...

Reviewers

Groups

reviewboard

People

Description

The image review UI sends its serialized comments as an object rather than an
array, which wasn't at all clear from the code, and only emerged when I
actually tried to use it. I've changed the code back to using _.each to
iterate over it, and added a comment as to why.

Testing Done

Was able to use the image review UI again.

Expand All
Collapse All

Ship it!

```
Ship It!
```

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/models/abstractReviewableModel.es6.js



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/models/abstractReviewableModel.es6.js

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (1f0e3a3)