Summary

Add ETag data generation to the avatar service API

Review Request #8566 — Created Dec. 12, 2016 and submitted Dec. 16, 2016, 2:11 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-0.10.x

Bugs

Depends On

Blocks

8567

Commit

65586a2...

Reviewers

Groups

djblets

People

Description

Avatar services can now generate ETag (Entity Tag) data to be used in
generating caching information for the avatars. This will allow pages
that use the avatar to be cached and only retrieved if the avatar
changes.

Testing Done

Tested this with Review Board in /r/8567. Saw that it worked correctly.

Issues

Description	From	Last Updated
It also doesn't need to be in any particular order, it just needs to be a stable sort.	david	Dec. 15, 2016, 12:07 p.m.
This could be very slightly improved: for key, value in sorted(urls): data.append(key) data.append(value)	david	Dec. 16, 2016, 12:53 p.m.

Tool: PEP8 Style Checker
Processed Files:
    djblets/avatars/services/url.py
    djblets/avatars/services/file_upload.py
    djblets/avatars/services/gravatar.py
    djblets/avatars/services/base.py



Tool: Pyflakes
Processed Files:
    djblets/avatars/services/url.py
    djblets/avatars/services/file_upload.py
    djblets/avatars/services/gravatar.py
    djblets/avatars/services/base.py

djblets/avatars/services/url.py (Diff revision 1)

The issue has been resolved. Show all issues

It also doesn't need to be in any particular order, it just needs to be a stable sort.

Change Summary:

Addressed David's issue

Diff:

Revision 2 (+98 -1)

Show changes

	djblets/avatars/services/base.py
	djblets/avatars/services/file_upload.py
	djblets/avatars/services/gravatar.py
	djblets/avatars/services/url.py

Tool: Pyflakes
Processed Files:
    djblets/avatars/services/url.py
    djblets/avatars/services/file_upload.py
    djblets/avatars/services/gravatar.py
    djblets/avatars/services/base.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/avatars/services/url.py
    djblets/avatars/services/file_upload.py
    djblets/avatars/services/gravatar.py
    djblets/avatars/services/base.py

Ship it!

djblets/avatars/services/url.py (Diff revision 2)

The issue has been dropped. Show all issues

This could be very slightly improved:

for key, value in sorted(urls):
    data.append(key)
    data.append(value)

Status:: Completed
Change Summary:: Pushed to release-0.10.x (93e4325)