Summary

Convert "Reviewable" model and view classes to ES6.

Review Request #8556 — Created Nov. 29, 2016 and submitted Nov. 29, 2016, 5:15 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

6188e66...

Reviewers

Groups

reviewboard

People

Description

This is a pretty straightforward transformation of all the remaining

reviewables. The transformations in here are pretty straightforward: fixing up

documentation comments, making use of some additional syntactic sugar,

switching var for let/const, etc.

Testing Done

Ran js-tests.

Issues

Description	From	Last Updated
tip - 1	chipx86	Nov. 29, 2016, 2 p.m.
base - 1	chipx86	Nov. 29, 2016, 2:01 p.m.
Blank line between these.	chipx86	Nov. 29, 2016, 2:01 p.m.
tip - 1	chipx86	Nov. 29, 2016, 2:05 p.m.
base - 1	chipx86	Nov. 29, 2016, 2:05 p.m.
Blank line between these.	chipx86	Nov. 29, 2016, 2:05 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/abstractReviewableView.es6.js
    reviewboard/static/rb/js/views/markdownReviewableView.es6.js
    reviewboard/static/rb/js/diffviewer/models/diffReviewableModel.es6.js
    reviewboard/static/rb/js/views/fileAttachmentReviewableView.es6.js
    reviewboard/static/rb/js/models/abstractReviewableModel.es6.js
    reviewboard/static/rb/js/models/fileAttachmentReviewableModel.es6.js
    reviewboard/static/rb/js/models/dummyReviewableModel.es6.js
    reviewboard/static/rb/js/models/screenshotReviewableModel.es6.js
    reviewboard/static/rb/js/views/dummyReviewableView.es6.js
    reviewboard/static/rb/js/models/textBasedReviewableModel.es6.js
    reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js
    reviewboard/static/rb/js/views/textBasedReviewableView.es6.js



Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/abstractReviewableView.es6.js
    reviewboard/static/rb/js/views/markdownReviewableView.es6.js
    reviewboard/static/rb/js/diffviewer/models/diffReviewableModel.es6.js
    reviewboard/static/rb/js/views/fileAttachmentReviewableView.es6.js
    reviewboard/static/rb/js/models/abstractReviewableModel.es6.js
    reviewboard/static/rb/js/models/fileAttachmentReviewableModel.es6.js
    reviewboard/static/rb/js/models/dummyReviewableModel.es6.js
    reviewboard/static/rb/js/models/screenshotReviewableModel.es6.js
    reviewboard/static/rb/js/views/dummyReviewableView.es6.js
    reviewboard/static/rb/js/models/textBasedReviewableModel.es6.js
    reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js
    reviewboard/static/rb/js/views/textBasedReviewableView.es6.js

reviewboard/static/rb/js/views/dummyReviewableView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
tip - 1
```
reviewboard/static/rb/js/views/dummyReviewableView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
base - 1
```
reviewboard/static/rb/js/views/dummyReviewableView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
tip - 1
```
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
base - 1
```
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```

Commit:

-	f16576f460e4457b23332a8f27cd07e99dc905ee
+	6188e66a38393689316de65700a52703fa1e107a

Diff:

Revision 2 (+366 -296)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/diffviewer/models/diffReviewableModel.js
	reviewboard/static/rb/js/models/abstractReviewableModel.js
	reviewboard/static/rb/js/models/dummyReviewableModel.js
	reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js
	reviewboard/static/rb/js/models/fileAttachmentReviewableModel.es6.js
	reviewboard/static/rb/js/models/screenshotReviewableModel.js
	reviewboard/static/rb/js/models/textBasedReviewableModel.js
	5 more

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/abstractReviewableView.es6.js
    reviewboard/static/rb/js/views/markdownReviewableView.es6.js
    reviewboard/static/rb/js/diffviewer/models/diffReviewableModel.es6.js
    reviewboard/static/rb/js/views/fileAttachmentReviewableView.es6.js
    reviewboard/static/rb/js/models/abstractReviewableModel.es6.js
    reviewboard/static/rb/js/models/fileAttachmentReviewableModel.es6.js
    reviewboard/static/rb/js/models/dummyReviewableModel.es6.js
    reviewboard/static/rb/js/models/screenshotReviewableModel.es6.js
    reviewboard/static/rb/js/views/dummyReviewableView.es6.js
    reviewboard/static/rb/js/models/textBasedReviewableModel.es6.js
    reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js
    reviewboard/static/rb/js/views/textBasedReviewableView.es6.js



Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/abstractReviewableView.es6.js
    reviewboard/static/rb/js/views/markdownReviewableView.es6.js
    reviewboard/static/rb/js/diffviewer/models/diffReviewableModel.es6.js
    reviewboard/static/rb/js/views/fileAttachmentReviewableView.es6.js
    reviewboard/static/rb/js/models/abstractReviewableModel.es6.js
    reviewboard/static/rb/js/models/fileAttachmentReviewableModel.es6.js
    reviewboard/static/rb/js/models/dummyReviewableModel.es6.js
    reviewboard/static/rb/js/models/screenshotReviewableModel.es6.js
    reviewboard/static/rb/js/views/dummyReviewableView.es6.js
    reviewboard/static/rb/js/models/textBasedReviewableModel.es6.js
    reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js
    reviewboard/static/rb/js/views/textBasedReviewableView.es6.js

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (0dc1773)