Convert "Reviewable" model and view classes to ES6.

Review Request #8556 — Created Nov. 29, 2016 and submitted

Information

Review Board
release-3.0.x
6188e66...

Reviewers

This is a pretty straightforward transformation of all the remaining
reviewables. The transformations in here are pretty straightforward: fixing up
documentation comments, making use of some additional syntactic sugar,
switching var for let/const, etc.

Ran js-tests.

Description From Last Updated

tip - 1

chipx86chipx86

base - 1

chipx86chipx86

Blank line between these.

chipx86chipx86

tip - 1

chipx86chipx86

base - 1

chipx86chipx86

Blank line between these.

chipx86chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/abstractReviewableView.es6.js
        reviewboard/static/rb/js/views/markdownReviewableView.es6.js
        reviewboard/static/rb/js/diffviewer/models/diffReviewableModel.es6.js
        reviewboard/static/rb/js/views/fileAttachmentReviewableView.es6.js
        reviewboard/static/rb/js/models/abstractReviewableModel.es6.js
        reviewboard/static/rb/js/models/fileAttachmentReviewableModel.es6.js
        reviewboard/static/rb/js/models/dummyReviewableModel.es6.js
        reviewboard/static/rb/js/models/screenshotReviewableModel.es6.js
        reviewboard/static/rb/js/views/dummyReviewableView.es6.js
        reviewboard/static/rb/js/models/textBasedReviewableModel.es6.js
        reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js
        reviewboard/static/rb/js/views/textBasedReviewableView.es6.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/abstractReviewableView.es6.js
        reviewboard/static/rb/js/views/markdownReviewableView.es6.js
        reviewboard/static/rb/js/diffviewer/models/diffReviewableModel.es6.js
        reviewboard/static/rb/js/views/fileAttachmentReviewableView.es6.js
        reviewboard/static/rb/js/models/abstractReviewableModel.es6.js
        reviewboard/static/rb/js/models/fileAttachmentReviewableModel.es6.js
        reviewboard/static/rb/js/models/dummyReviewableModel.es6.js
        reviewboard/static/rb/js/models/screenshotReviewableModel.es6.js
        reviewboard/static/rb/js/views/dummyReviewableView.es6.js
        reviewboard/static/rb/js/models/textBasedReviewableModel.es6.js
        reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js
        reviewboard/static/rb/js/views/textBasedReviewableView.es6.js
    
    
  2. 
      
chipx86
  1. 
      
  2. Show all issues

    tip - 1

  3. Show all issues

    base - 1

  4. Show all issues

    Blank line between these.

  5. Show all issues

    tip - 1

  6. Show all issues

    base - 1

  7. Show all issues

    Blank line between these.

  8. 
      
david
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/abstractReviewableView.es6.js
        reviewboard/static/rb/js/views/markdownReviewableView.es6.js
        reviewboard/static/rb/js/diffviewer/models/diffReviewableModel.es6.js
        reviewboard/static/rb/js/views/fileAttachmentReviewableView.es6.js
        reviewboard/static/rb/js/models/abstractReviewableModel.es6.js
        reviewboard/static/rb/js/models/fileAttachmentReviewableModel.es6.js
        reviewboard/static/rb/js/models/dummyReviewableModel.es6.js
        reviewboard/static/rb/js/models/screenshotReviewableModel.es6.js
        reviewboard/static/rb/js/views/dummyReviewableView.es6.js
        reviewboard/static/rb/js/models/textBasedReviewableModel.es6.js
        reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js
        reviewboard/static/rb/js/views/textBasedReviewableView.es6.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/abstractReviewableView.es6.js
        reviewboard/static/rb/js/views/markdownReviewableView.es6.js
        reviewboard/static/rb/js/diffviewer/models/diffReviewableModel.es6.js
        reviewboard/static/rb/js/views/fileAttachmentReviewableView.es6.js
        reviewboard/static/rb/js/models/abstractReviewableModel.es6.js
        reviewboard/static/rb/js/models/fileAttachmentReviewableModel.es6.js
        reviewboard/static/rb/js/models/dummyReviewableModel.es6.js
        reviewboard/static/rb/js/models/screenshotReviewableModel.es6.js
        reviewboard/static/rb/js/views/dummyReviewableView.es6.js
        reviewboard/static/rb/js/models/textBasedReviewableModel.es6.js
        reviewboard/static/rb/js/models/fileAttachmentReviewableModel.js
        reviewboard/static/rb/js/views/textBasedReviewableView.es6.js
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (0dc1773)