Convert comment block models and views to ES6.

Review Request #8555 — Created Nov. 27, 2016 and submitted

Information

Review Board
release-3.0.x
e092196...

Reviewers

This change moves over another chunk of our javascript code to ES6. The
transformations in here are pretty straightforward: fixing up documentation
comments, making use of some additional syntactic sugar, switching var for
let/const, etc.

Ran js-tests.

Description From Last Updated

/**

brenniebrennie

Drop the comma while you're here?

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.es6.js
        reviewboard/static/rb/js/models/screenshotCommentBlockModel.es6.js
        reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.es6.js
        reviewboard/static/rb/js/views/textBasedCommentBlockView.es6.js
        reviewboard/static/rb/js/models/abstractCommentBlockModel.es6.js
        reviewboard/static/rb/js/models/regionCommentBlockModel.es6.js
        reviewboard/static/rb/js/models/fileAttachmentCommentBlockModel.es6.js
        reviewboard/static/rb/js/models/textBasedCommentBlockModel.es6.js
        reviewboard/static/rb/js/views/abstractCommentBlockView.es6.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.es6.js
        reviewboard/static/rb/js/models/screenshotCommentBlockModel.es6.js
        reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.es6.js
        reviewboard/static/rb/js/views/textBasedCommentBlockView.es6.js
        reviewboard/static/rb/js/models/abstractCommentBlockModel.es6.js
        reviewboard/static/rb/js/models/regionCommentBlockModel.es6.js
        reviewboard/static/rb/js/models/fileAttachmentCommentBlockModel.es6.js
        reviewboard/static/rb/js/models/textBasedCommentBlockModel.es6.js
        reviewboard/static/rb/js/views/abstractCommentBlockView.es6.js
    
    
  2. 
      
brennie
  1. 
      
  2. Show all issues

    Drop the comma while you're here?

  3. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.es6.js
        reviewboard/static/rb/js/models/screenshotCommentBlockModel.es6.js
        reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.es6.js
        reviewboard/static/rb/js/views/textBasedCommentBlockView.es6.js
        reviewboard/static/rb/js/models/abstractCommentBlockModel.es6.js
        reviewboard/static/rb/js/models/regionCommentBlockModel.es6.js
        reviewboard/static/rb/js/models/fileAttachmentCommentBlockModel.es6.js
        reviewboard/static/rb/js/views/abstractCommentBlockView.es6.js
        reviewboard/static/rb/js/models/textBasedCommentBlockModel.es6.js
        reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.es6.js
        reviewboard/static/rb/js/models/screenshotCommentBlockModel.es6.js
        reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.es6.js
        reviewboard/static/rb/js/views/textBasedCommentBlockView.es6.js
        reviewboard/static/rb/js/models/abstractCommentBlockModel.es6.js
        reviewboard/static/rb/js/models/regionCommentBlockModel.es6.js
        reviewboard/static/rb/js/models/fileAttachmentCommentBlockModel.es6.js
        reviewboard/static/rb/js/views/abstractCommentBlockView.es6.js
        reviewboard/static/rb/js/models/textBasedCommentBlockModel.es6.js
        reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (3e066ed)
Loading...