Summary

Add some additional query options to the status updates list API.

Review Request #8552 — Created Nov. 22, 2016 and submitted Nov. 29, 2016, 1:19 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

5e50a8e...

Reviewers

Groups

reviewboard

People

Description

This change adds a few additional options to the status updates list API for
querying by the change description, service ID, or state.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 22, 2016, 11:52 p.m.
&= ?	brennie	Nov. 24, 2016, 10:53 a.m.
.filter(Q()) is equivalent to .all() so you rewrite this all as: q = Q() if is_list: # ... return review_request.status_updates.filter(q)	brennie	Nov. 29, 2016, 1:08 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/tests/test_status_update.py
    reviewboard/webapi/resources/status_update.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/tests/test_status_update.py
    reviewboard/webapi/resources/status_update.py

reviewboard/testing/testcase.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```

reviewboard/webapi/resources/status_update.py (Diff revision 1)
The issue has been dropped. Show all issues
```
&= ?
```
1. david Nov. 24, 2016, 10:53 a.m.
  For some reason, we don't use this form anywhere. I'd rather stay consistent with existing code.

Ship it!

reviewboard/webapi/resources/status_update.py (Diff revision 1)

The issue has been resolved. Show all issues

.filter(Q()) is equivalent to .all() so you rewrite this all as:

q = Q()

if is_list:
    # ...

return review_request.status_updates.filter(q)

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (45f8fa0)