Fix up markup and styles for the review dialog.

Review Request #8545 — Created Nov. 17, 2016 and submitted

Information

Review Board
release-3.0.x
bc9ccb4...

Reviewers

We're going to be rewriting the review dialog to be very much improved, but in
the meantime, some layout and style problems had snuck in as a result of the
recent review changes. This change fixes those up as a stop-gap measure so that
we have something shippable before the new review experience work gets done. The
styles are mostly copied from the review entries, with appropriate changes to
make things fit in to the dialog. I haven't spent too much time making the code
perfectly factored because all of this is going to be rewritten anyway.

  • Created a draft review with different types of comments and verified that
    everything looked good.
  • Opened and closed editors for header, footer, and different comments, making
    sure that none of the text jumped around.

Description From Last Updated

I like this!

brenniebrennie
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.es6.js
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/pages/reviews.less
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.es6.js
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/pages/reviews.less
    
    
  2. 
      
david
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.es6.js
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/pages/reviews.less
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/reviewDialogView.es6.js
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/pages/reviews.less
    
    
  2. 
      
brennie
  1. 
      
  2. Show all issues

    I like this!

    1. Oops, this wasn't supposed to be an issue.

  3. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (dcb1b56)
Loading...