Fix up markup and styles for the review dialog.
Review Request #8545 — Created Nov. 17, 2016 and submitted
We're going to be rewriting the review dialog to be very much improved, but in
the meantime, some layout and style problems had snuck in as a result of the
recent review changes. This change fixes those up as a stop-gap measure so that
we have something shippable before the new review experience work gets done. The
styles are mostly copied from the review entries, with appropriate changes to
make things fit in to the dialog. I haven't spent too much time making the code
perfectly factored because all of this is going to be rewritten anyway.
- Created a draft review with different types of comments and verified that
everything looked good. - Opened and closed editors for header, footer, and different comments, making
sure that none of the text jumped around.
Description | From | Last Updated |
---|---|---|
I like this! |
brennie |
- Change Summary:
-
Fix margin/width for diffs, alphabetize. This also includes a port of /r/8546
- Commit:
-
30b37b4c73cd2a8c5d5e853bda8702d3b7517ca6bc9ccb43827bb20cc1d72992094f2e917fc07c27
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.es6.js reviewboard/static/rb/css/defs.less reviewboard/static/rb/css/pages/reviews.less Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/reviewDialogView.es6.js reviewboard/static/rb/css/defs.less reviewboard/static/rb/css/pages/reviews.less