Summary

Port reviewDialogView.js to ES6.

Review Request #8543 — Created Nov. 16, 2016 and submitted Nov. 21, 2016, 9:46 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

29d9201...

Reviewers

Groups

reviewboard

People

Description

In preparation for some minor cleanups to the markup and style to fix
regressions introduced by the review changes I made earlier, I've converted
this file over to ES6.

Testing Done

Ran js-tests.

Issues

Description	From	Last Updated
Can you add area-hidden="true" to the <span>? This prevents it from being read by screen readers.	brennie	Nov. 18, 2016, 10:26 p.m.
Use change:${this._getRawValueFieldName()} ?	brennie	Nov. 18, 2016, 10:30 p.m.
_updateRawValue()	brennie	Nov. 18, 2016, 10:30 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.es6.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.es6.js

reviewboard/static/rb/js/views/reviewDialogView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you add area-hidden="true" to the <span>? This prevents it from being read by screen readers.
```

reviewboard/static/rb/js/views/reviewDialogView.es6.js (Diff revision 1)

Does $.fn.append() transform strings to elements?

david Nov. 18, 2016, 10:30 p.m.

Yep. append() takes any of htmlString, Element, Text, Array, or jQuery.

reviewboard/static/rb/js/views/reviewDialogView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Use change:${this._getRawValueFieldName()} ?
```
reviewboard/static/rb/js/views/reviewDialogView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
_updateRawValue()
```

Commit:

-	e1e6616e63f535425456f2abedef8904614d8b5f
+	29d9201759d225a62f63bdc00bcf110c71eced48

Diff:

Revision 2 (+576 -438)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/views/reviewDialogView.js

Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.es6.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.es6.js

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (d849004)