Do not use BuiltinLocalsFieldMixin for the DiffCommitListField

Review Request #8542 — Created Nov. 15, 2016 and submitted

brennie
Review Board
dvcs
reviewboard

The DiffCommitListField was using the BuiltinLocalsFieldMixin but
not taking advantage of it because it required the data in the actual
review request view as well as in the change description portions. Since
it was building all the data itself anyway, this class no longer uses
the mixin.

It still works!

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/views.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/views.py
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/reviews/builtin_fields.py (Diff revision 1)
     
     

    Mind adding a trailing comma?

  3. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to dvcs (44614b3)
Loading...