Summary

Do not use BuiltinLocalsFieldMixin for the DiffCommitListField

Review Request #8542 — Created Nov. 15, 2016 and submitted Nov. 16, 2016, 8:25 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The DiffCommitListField was using the BuiltinLocalsFieldMixin but

not taking advantage of it because it required the data in the actual

review request view as well as in the change description portions. Since

it was building all the data itself anyway, this class no longer uses

the mixin.

Testing Done

It still works!

Issues

Description	From	Last Updated
Mind adding a trailing comma?	david	Nov. 16, 2016, 8:13 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/builtin_fields.py
    reviewboard/reviews/views.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/builtin_fields.py
    reviewboard/reviews/views.py

Ship it!

reviewboard/reviews/builtin_fields.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Mind adding a trailing comma?
```

Status: Closed (submitted)

Change Summary:

Pushed to dvcs (44614b3)