Don't create a review if there are no comments.

Review Request #8533 — Created Nov. 10, 2016 and submitted

Information

ReviewBot
master
eae85ee...

Reviewers

If a Review Bot tool doesn't have anything to say, we don't want to create and
publish an empty review (since doing so would still send an e-mail). This
change fixes it so we only create a review associated with the status update if
there are comments.

Triggered a tool that resulted in zero comments, and checked the resulting
status update. No review was created or associated.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        bot/reviewbot/tasks.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        bot/reviewbot/tasks.py
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (ae97396)
Loading...