Summary

Refactor the DummyAvatarService into two services

Review Request #8526 — Created Nov. 7, 2016 and submitted Nov. 9, 2016, 3:08 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-0.10.x

Bugs

Depends On

Blocks

8528

Reviewers

Groups

djblets

People

Description

The DummyAvatarService no longer does magic to set whether or not it
should provide high DPI avatars. Instead, we now have the
DummyHighDPIAvatarService to provide that (and the
DummyAvatarService will not provide high DPI avatars).

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Typo in description: "mangaer"	david	Nov. 7, 2016, 5:48 p.m.
Typo in description: "havw"	david	Nov. 9, 2016, 2:59 p.m.
"Initialize and return ..."?	david	Nov. 7, 2016, 5:48 p.m.
Missing "Returns".	chipx86	Nov. 7, 2016, 5:48 p.m.
This line shouldn't be here.	david	Nov. 9, 2016, 3 p.m.

Tool: Pyflakes
Processed Files:
    djblets/avatars/tests.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/avatars/tests.py

The issue has been resolved. Show all issues
```
Typo in description: "mangaer"
```
djblets/avatars/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
"Initialize and return ..."?
```

I'm not fully understanding why we're using __call__ for this. Can you walk me through this?

Might also be good to be explicit in the docstrings about why this is happening. It's going to be confusing down the road.

djblets/avatars/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing "Returns".
```

Summary:

-	Make the dummy avatar service callable
+	Refactor the DummyAvatarService into two services

Description:

~		The dummy avatar service is now callable like the dummy settings
~		mangaer, which allows us to partially instantiate it during `__init__`
~		and finish instantiation in `__call__`. This allows us to set whether
~		or not we want to use high DPI avatars before the avatar service is
	~	The `DummyAvatarService` no longer does magic to set whether or not it
	~	should provide high DPI avatars. Instead, we now havw the
	~	`DummyHighDPIAvatarService` to provide that (and the
	~	`DummyAvatarService` will not provide high DPI avatars).
-		fully instantiated with the settings manager (which we otherwise could
-		not do).

Diff:

Revision 2 (+63 -47)

Show changes

djblets/avatars/tests.py

Tool: Pyflakes
Processed Files:
    djblets/avatars/tests.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/avatars/tests.py

Ship it!

The issue has been resolved. Show all issues
```
Typo in description: "havw"
```
djblets/avatars/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This line shouldn't be here.
```

Description:

		The `DummyAvatarService` no longer does magic to set whether or not it
~		should provide high DPI avatars. Instead, we now havw the
	~	should provide high DPI avatars. Instead, we now have the
		`DummyHighDPIAvatarService` to provide that (and the
		`DummyAvatarService` will not provide high DPI avatars).

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (0342dde)

djblets/avatars/tests.py (Diff revision 1)

djblets/avatars/tests.py (Diff revision 1)

djblets/avatars/tests.py (Diff revision 2)