Refactor the DummyAvatarService into two services

Review Request #8526 - Created Nov. 7, 2016 and submitted

Barret Rennie
Djblets
release-0.10.x
8528
djblets

The DummyAvatarService no longer does magic to set whether or not it
should provide high DPI avatars. Instead, we now have the
DummyHighDPIAvatarService to provide that (and the
DummyAvatarService will not provide high DPI avatars).

Ran unit tests.

  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        djblets/avatars/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/avatars/tests.py
    
    
  2. 
      
David Trowbridge
  1. 
      
  2. Typo in description: "mangaer"

  3. djblets/avatars/tests.py (Diff revision 1)
     
     

    "Initialize and return ..."?

  4. 
      
Christian Hammond
  1. I'm not fully understanding why we're using __call__ for this. Can you walk me through this?

    Might also be good to be explicit in the docstrings about why this is happening. It's going to be confusing down the road.

  2. djblets/avatars/tests.py (Diff revision 1)
     
     
     
     
     

    Missing "Returns".

  3. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        djblets/avatars/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/avatars/tests.py
    
    
  2. 
      
David Trowbridge
  1. 
      
  2. Typo in description: "havw"

  3. djblets/avatars/tests.py (Diff revision 2)
     
     

    This line shouldn't be here.

  4. 
      
Barret Rennie
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (0342dde)
Loading...