Provide true Review Board versions of Extension/JSExtension classes.

Review Request #8518 — Created Nov. 3, 2016 and submitted

Information

Review Board
release-2.5.x
5bf34b2...

Reviewers

The reviewboard.extensions.base module was forwarding the
Extension/JSExtension classes from Djblets. This basically meant we had
a copy of the class, rather than a version specific to Review Board. In
practice, that's not so bad, but it also meant that we couldn't have
documentation specific to Review Board, and we also weren't properly
carrying over documentation from Djblets (due to "#:" lines not carrying
over).

We now have local subclasses instead, which we can document and use to
point back to the parent class documentation.

The rest of this file has also been documented.

Unit tests pass.

Existing extensions still work.

Built and viewed documentation.

reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/extensions/base.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/extensions/base.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (240fc3f)
Loading...