-
-
-
reviewboard/settings.py (Diff revision 1) 'from settings_local import *' used; unable to detect undefined names
Use babel-plugin-dedent in Review Board.
Review Request #8515 — Created Nov. 2, 2016 and submitted
Information | |
---|---|
david | |
Review Board | |
release-3.0.x | |
|
|
7357b39... | |
Reviewers | |
reviewboard | |
In another change, I've added an npm dependency to Djblets to install
babel-plugin-dedent, which allows us to use ES6 template strings without
filling our compiled output with a ton of ugly spaces. This change enables it
for Review Board as well.
- Ran
setup.py develop
and saw babel-plugin-dedent get installed correctly. - Used the dedent tag in extension code.
Description | From | Last Updated |
---|---|---|
This will need to also handle the extension packaging side. Right now, djblets.extensions.packaging:BuildStaticFiles.install_pipeline_dependencies installs the necessary NPM packages depending on … |
|
|
'django_reset' imported but unused |
![]() |
|
'from settings_local import *' used; unable to detect undefined names |
![]() |
|
Should be alphabetical. |
|
|
'django_reset' imported but unused |
![]() |
|
'from settings_local import *' used; unable to detect undefined names |
![]() |

-
-
This will need to also handle the extension packaging side. Right now,
djblets.extensions.packaging:BuildStaticFiles.install_pipeline_dependencies
installs the necessary NPM packages depending on what's being used. We should either say that we're leaning on this for Djblets (which we probably should anyway -- we might want this plugin for Djblets JavaScript code) or we'll need to override this behavior in Review Board (which will require some Djblets work anyway to make that easier).I'd say let's just move this change over to Djblets instead, and then we'll get the best of all worlds.
-
Summary: |
|
|||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||||||||||||||||||
Depends On: |
|
|||||||||||||||||||||||||||||||||||||||
Commit: |
|
|||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+2 -1) |

-
Tool: Pyflakes Processed Files: reviewboard/settings.py Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py
-
-
reviewboard/settings.py (Diff revision 2) 'from settings_local import *' used; unable to detect undefined names