Check for node and nodejs when running setup.py develop.
Review Request #8511 — Created Oct. 31, 2016 and submitted — Latest diff uploaded
If node isn't installed,
setup.py develop
will fail part-way through
the installation process. However, if it's installed but asnodejs
(such as on Ubuntu), it will all work correctly until you go to run
Review Board, at which point it will fail confusingly when it fails to
findnode
in the path.We now check for both
node
andnodejs
, and provide appropriate error
messages depending on what we find or don't find.
Tested with
node
in the path and without.Tested without
node
in the path but with and withoutnodejs
in the
path.Saw the expected behavior in all cases.