Summary

Check for node and nodejs when running setup.py develop.

Review Request #8511 — Created Oct. 31, 2016 and submitted Nov. 17, 2016, 2:28 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-0.8.x

Bugs

Depends On

Commit

0ee16b5...

Reviewers

Groups

djblets

People

Description

If node isn't installed, setup.py develop will fail part-way through
the installation process. However, if it's installed but as nodejs
(such as on Ubuntu), it will all work correctly until you go to run
Review Board, at which point it will fail confusingly when it fails to
find node in the path.

We now check for both node and nodejs, and provide appropriate error
messages depending on what we find or don't find.

Testing Done

Tested with node in the path and without.

Tested without node in the path but with and without nodejs in the
path.

Saw the expected behavior in all cases.

Issues

Description	From	Last Updated
This second sentence is a little confusing.	david	Oct. 31, 2016, 2:19 p.m.

Tool: PEP8 Style Checker
Processed Files:
    setup.py



Tool: Pyflakes
Processed Files:
    setup.py

Change Summary:

Removed an exception case I was using for testing only.

Commit:

-	0c424905b2a7df6cf1d8c5ddeefe9ad2496b855d
+	1a4054ac6f2a809bfcef7ad892f29dce308248fb

Diff:

Revision 2 (+20 -1)

Show changes

setup.py

Tool: PEP8 Style Checker
Processed Files:
    setup.py



Tool: Pyflakes
Processed Files:
    setup.py

setup.py (Diff revision 2)

The issue has been resolved. Show all issues

This second sentence is a little confusing.

chipx86 Oct. 31, 2016, 2:20 p.m.

Not sure if I've made it better or worse, but give me your thoughts on the latest wording.

david Oct. 31, 2016, 2:22 p.m.

Better, but ln -s definitely isn't going to work on Windows.

chipx86 Oct. 31, 2016, 5:46 p.m.

True, but this is really only an Ubuntu problem. They rename it because of a legacy package with a binary called "node". Everywhere else, it's just installed as "node".

Commit:

-	1a4054ac6f2a809bfcef7ad892f29dce308248fb
+	0ee16b5ce653247c4985aeeea04af7aef6208e5b

Diff:

Revision 3 (+21 -1)

Show changes

setup.py

Tool: Pyflakes
Processed Files:
    setup.py



Tool: PEP8 Style Checker
Processed Files:
    setup.py

Ship it!

```
Ship It!
```

setup.py (Diff revision 3)

I think check_output was added in Python 2.7, but doesn't this version of Djblets support Python 2.6? Ditto below.

chipx86 Nov. 1, 2016, 12:50 p.m.

Good catch. I'll have to adjust this.

I had originally used check_call, but that ends up outputting content.. I'll have to look into options here.

Status: Closed (submitted)

Change Summary:

Pushed to release-0.8.x (aca66dc)