Summary

Add custom status rendering support to integrations

Review Request #8491 — Created Oct. 25, 2016 and submitted Oct. 28, 2016, 5:04 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-0.10.x

Bugs

Depends On

Blocks

8496

Reviewers

Groups

djblets

People

Description

Integrations can now customize how they render their entries in the
integration list view via the render_config_status method. By
default, it just renders whether or not the integration is enabled
(which was the original behaviour).

Additionally, the aria-hidden attribute was added to FontAwesome
icons to prevent them from being read by screen readers.

Testing Done

Tested with rb-integrations and Review Board.

Issues

Description	From	Last Updated
'reverse' imported but unused	reviewbot	Oct. 25, 2016, 9:43 p.m.
'_' imported but unused	reviewbot	Oct. 25, 2016, 9:43 p.m.
Needs "Args"	david	Oct. 28, 2016, 4:34 p.m.
Mind sorting this alphabetically?	david	Oct. 28, 2016, 4:33 p.m.

Tool: PEP8 Style Checker
Processed Files:
    djblets/integrations/templatetags/integrations.py
    djblets/integrations/integration.py
    djblets/integrations/views.py

Ignored Files:
    djblets/integrations/templates/integrations/integration_list.html
    djblets/integrations/templatetags/__init__.py
    djblets/integrations/templates/integrations/integration_status.html



Tool: Pyflakes
Processed Files:
    djblets/integrations/templatetags/integrations.py
    djblets/integrations/integration.py
    djblets/integrations/views.py

Ignored Files:
    djblets/integrations/templates/integrations/integration_list.html
    djblets/integrations/templatetags/__init__.py
    djblets/integrations/templates/integrations/integration_status.html

djblets/integrations/integration.py (Diff revision 1)
Show all issues
```
 'reverse' imported but unused
```
djblets/integrations/integration.py (Diff revision 1)
Show all issues
```
 '_' imported but unused
```

Diff:

Revision 2 (+59 -11)

Show changes

	djblets/integrations/integration.py
	djblets/integrations/views.py
	djblets/integrations/templates/integrations/integration_list.html
	djblets/integrations/templates/integrations/integration_status.html
	djblets/integrations/templatetags/__init__.py
	djblets/integrations/templatetags/integrations.py

Tool: PEP8 Style Checker
Processed Files:
    djblets/integrations/templatetags/integrations.py
    djblets/integrations/integration.py
    djblets/integrations/views.py

Ignored Files:
    djblets/integrations/templates/integrations/integration_list.html
    djblets/integrations/templatetags/__init__.py
    djblets/integrations/templates/integrations/integration_status.html



Tool: Pyflakes
Processed Files:
    djblets/integrations/templatetags/integrations.py
    djblets/integrations/integration.py
    djblets/integrations/views.py

Ignored Files:
    djblets/integrations/templates/integrations/integration_list.html
    djblets/integrations/templatetags/__init__.py
    djblets/integrations/templates/integrations/integration_status.html

djblets/integrations/integration.py (Diff revision 2)
Show all issues
```
Needs "Args"
```

djblets/integrations/views.py (Diff revision 2)

Show all issues

Mind sorting this alphabetically?

Diff:

Revision 3 (+66 -14)

Show changes

	djblets/integrations/integration.py
	djblets/integrations/views.py
	djblets/integrations/templates/integrations/integration_list.html
	djblets/integrations/templates/integrations/integration_status.html
	djblets/integrations/templatetags/__init__.py
	djblets/integrations/templatetags/integrations.py

Tool: Pyflakes
Processed Files:
    djblets/integrations/templatetags/integrations.py
    djblets/integrations/integration.py
    djblets/integrations/views.py

Ignored Files:
    djblets/integrations/templates/integrations/integration_list.html
    djblets/integrations/templatetags/__init__.py
    djblets/integrations/templates/integrations/integration_status.html



Tool: PEP8 Style Checker
Processed Files:
    djblets/integrations/templatetags/integrations.py
    djblets/integrations/integration.py
    djblets/integrations/views.py

Ignored Files:
    djblets/integrations/templates/integrations/integration_list.html
    djblets/integrations/templatetags/__init__.py
    djblets/integrations/templates/integrations/integration_status.html

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (f3307ba)