Add custom status rendering support to integrations

Review Request #8491 - Created Oct. 25, 2016 and submitted

Barret Rennie
Djblets
release-0.10.x
8496
djblets

Integrations can now customize how they render their entries in the
integration list view via the render_config_status method. By
default, it just renders whether or not the integration is enabled
(which was the original behaviour).

Additionally, the aria-hidden attribute was added to FontAwesome
icons to prevent them from being read by screen readers.

Tested with rb-integrations and Review Board.

  • 0
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
Review Bot
  1. Tool: PEP8 Style Checker
    Processed Files:
        djblets/integrations/templatetags/integrations.py
        djblets/integrations/integration.py
        djblets/integrations/views.py
    
    Ignored Files:
        djblets/integrations/templates/integrations/integration_list.html
        djblets/integrations/templatetags/__init__.py
        djblets/integrations/templates/integrations/integration_status.html
    
    
    
    Tool: Pyflakes
    Processed Files:
        djblets/integrations/templatetags/integrations.py
        djblets/integrations/integration.py
        djblets/integrations/views.py
    
    Ignored Files:
        djblets/integrations/templates/integrations/integration_list.html
        djblets/integrations/templatetags/__init__.py
        djblets/integrations/templates/integrations/integration_status.html
    
    
  2. djblets/integrations/integration.py (Diff revision 1)
     
     
     'reverse' imported but unused
    
  3. djblets/integrations/integration.py (Diff revision 1)
     
     
     '_' imported but unused
    
  4. 
      
Barret Rennie
Review Bot
  1. Tool: PEP8 Style Checker
    Processed Files:
        djblets/integrations/templatetags/integrations.py
        djblets/integrations/integration.py
        djblets/integrations/views.py
    
    Ignored Files:
        djblets/integrations/templates/integrations/integration_list.html
        djblets/integrations/templatetags/__init__.py
        djblets/integrations/templates/integrations/integration_status.html
    
    
    
    Tool: Pyflakes
    Processed Files:
        djblets/integrations/templatetags/integrations.py
        djblets/integrations/integration.py
        djblets/integrations/views.py
    
    Ignored Files:
        djblets/integrations/templates/integrations/integration_list.html
        djblets/integrations/templatetags/__init__.py
        djblets/integrations/templates/integrations/integration_status.html
    
    
  2. 
      
David Trowbridge
  1. 
      
  2. djblets/integrations/integration.py (Diff revision 2)
     
     

    Needs "Args"

  3. djblets/integrations/views.py (Diff revision 2)
     
     
     
     
     
     
     

    Mind sorting this alphabetically?

  4. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        djblets/integrations/templatetags/integrations.py
        djblets/integrations/integration.py
        djblets/integrations/views.py
    
    Ignored Files:
        djblets/integrations/templates/integrations/integration_list.html
        djblets/integrations/templatetags/__init__.py
        djblets/integrations/templates/integrations/integration_status.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/integrations/templatetags/integrations.py
        djblets/integrations/integration.py
        djblets/integrations/views.py
    
    Ignored Files:
        djblets/integrations/templates/integrations/integration_list.html
        djblets/integrations/templatetags/__init__.py
        djblets/integrations/templates/integrations/integration_status.html
    
    
  2. 
      
David Trowbridge
  1. Ship It!
  2. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (f3307ba)
Loading...