Col: 5 E265 block comment should start with '# '

Col: 80 E501 line too long (81 > 79 characters)

Col: 80 E501 line too long (81 > 79 characters)

Col: 80 W291 trailing whitespace

local variable 'comment_text_1' is assigned to but never used

local variable 'comment_text_2' is assigned to but never used

local variable 'comment_text_3' is assigned to but never used

Col: 1 W293 blank line contains whitespace

local variable 'filediff' is assigned to but never used

local variable 'review_one' is assigned to but never used

Col: 80 E501 line too long (81 > 79 characters)

local variable 'review_two' is assigned to but never used

Col: 80 E501 line too long (81 > 79 characters)

Col: 80 E501 line too long (83 > 79 characters)

local variable 'reply_for_three' is assigned to but never used

Col: 80 E501 line too long (82 > 79 characters)

local variable 'reply_for_four' is assigned to but never used

Col: 1 W293 blank line contains whitespace

Col: 80 E501 line too long (86 > 79 characters)

timestamps.

Instead of keeping track of i manually, you can do: for i, review in enumerate(review_request.reviews.all()): Review.objects.filter(pk=review.pk).update(timestamp=timestamp[i])

Col: 79 W291 trailing whitespace

Col: 9 E303 too many blank lines (2)

Col: 80 E501 line too long (83 > 79 characters)

Col: 1 W293 blank line contains whitespace

Col: 9 E303 too many blank lines (2)

Col: 1 W293 blank line contains whitespace

No print() in unit tests. YOu can add a message to self.assertEqual as the third argument.

Col: 1 W293 blank line contains whitespace

These should be together.

undo this.

Missing a period.

No blank line here.

Col: 1 W293 blank line contains whitespace

isinstance(entry, ReviewEntry)

These are only used in one place, so just put them inline.

Col: 80 E501 line too long (86 > 79 characters)

This should be if isinstance(latest_reply, basestring))

This should be if last_visited != 0 and isinstance(last_visited, basestring))

Col: 80 E501 line too long (81 > 79 characters)

This should be formatted as: collapsed = ( review.timestmap < oldest_allowed_time and (latest_reply is None or (latest_reply < oldest_allowed_time and …

Col: 25 E127 continuation line over-indented for visual indent

Col: 25 W503 line break before binary operator

Col: 50 W291 trailing whitespace

Col: 30 W503 line break before binary operator

Col: 68 W291 trailing whitespace

Undo this.

from datetime import datetime, timedelta

'datetime' imported but unused

Col: 80 E501 line too long (85 > 79 characters)

'ReviewRequest' imported but unused

Undo this.

Col: 19 E222 multiple spaces after operator

local variable 'diffset' is assigned to but never used

local variable 'user2' is assigned to but never used

Col: 22 E128 continuation line under-indented for visual indent

Col: 80 E501 line too long (91 > 79 characters)

These should all be in one group. Imports go as follows: from __future import unicode_literals python stdlib imports 3rdpart imports …

isinstance(i, cls) returns a bool.

latest_reply_timestamp

If it is not a string, what is it? If it is string or None, then you can just do …

Col: 80 E501 line too long (82 > 79 characters)

Col: 80 E501 line too long (81 > 79 characters)

Col: 80 E501 line too long (82 > 79 characters)

last_visited_time

Col: 80 E501 line too long (81 > 79 characters)

Col: 9 E303 too many blank lines (2)

Col: 69 E261 at least two spaces before inline comment

Col: 70 E262 inline comment should start with '# '

Col: 69 E261 at least two spaces before inline comment

Col: 70 E262 inline comment should start with '# '

Col: 78 E261 at least two spaces before inline comment

Col: 79 E262 inline comment should start with '# '

Col: 80 E501 line too long (88 > 79 characters)

Col: 78 E261 at least two spaces before inline comment

Col: 79 E262 inline comment should start with '# '

Col: 80 E501 line too long (88 > 79 characters)

Col: 78 E261 at least two spaces before inline comment

Col: 79 E262 inline comment should start with '# '

Col: 80 E501 line too long (90 > 79 characters)

Col: 78 E261 at least two spaces before inline comment

Col: 79 E262 inline comment should start with '# '

Col: 80 E501 line too long (89 > 79 characters)

Col: 80 E501 line too long (98 > 79 characters)

Col: 80 E501 line too long (82 > 79 characters)

local variable 'last_visited' is assigned to but never used

Col: 80 E501 line too long (83 > 79 characters)

Col: 29 E128 continuation line under-indented for visual indent

Col: 29 E128 continuation line under-indented for visual indent

Col: 26 E127 continuation line over-indented for visual indent

I will say use review_timestamp since you declared it.

This comment doesn't make sense to me. Can you flesh it out?

Comments should include periods at the end. Several other instances in this same method.

This could be: self.assertEqual( [entry.collapsed for entry in entries], expected_values)

It doesn't make sense to use indices here. for entry in entries: self.assertEqual(entry.collapsed, False)

Same comment as above re: direct iteration.

Same comment as above re: the expected_values check.

This is adding a new query for something which we already are fetching below. Instead of adding this, how about …

One major problem that this introduces is that a ChangeEntry or InitialStatusUpdatesEntry which contains multiple reviews (those attached to a …

What is "allowed" time?

In this case, it's probably cleaner to format this as: latest_reply_timestamp = \ data.latest_timestamps_by_review_id.get(review.pk)

This should all not be necessary anymore, right?

Draft reviews aren't shown in the review list. This can go away.

Indentation is a little off here. Should be: if (last_visited_time <= review_timestamp or (latest_reply_timestamp is not None and last_visited_time <= …

Too many blank lines here.

Why this change?

Something's weird with your change and what its parent commit is. This shouldn't be showing up in your diff.

Col: 19 E222 multiple spaces after operator

Col: 80 E501 line too long (82 > 79 characters)

This shouldn't be possible. Only top-level reviews get their own entry.

This will do the wrong thing for entries that are not ReviewEntry. We should just move this assignment into the …

You shouldn't need any special cases for these--they show up in reviews_entry_map.

Col: 1 W293 blank line contains whitespace

Col: 80 E501 line too long (81 > 79 characters)

Col: 80 E501 line too long (83 > 79 characters)

Col: 80 E501 line too long (84 > 79 characters)

Col: 50 E127 continuation line over-indented for visual indent

Col: 80 E501 line too long (83 > 79 characters)

Col: 80 E501 line too long (82 > 79 characters)

Col: 50 E127 continuation line over-indented for visual indent

Col: 40 E128 continuation line under-indented for visual indent

Col: 50 E127 continuation line over-indented for visual indent

Col: 40 E128 continuation line under-indented for visual indent

Col: 41 E127 continuation line over-indented for visual indent

Col: 51 E127 continuation line over-indented for visual indent

Col: 41 E127 continuation line over-indented for visual indent

Col: 50 E127 continuation line over-indented for visual indent

'StatusUpdate' imported but unused

Col: 21 E127 continuation line over-indented for visual indent

Col: 21 E127 continuation line over-indented for visual indent

You might want to split this up into multiple tests since it does a lot.

No period for test docstrings (the test runner adds periods).

No blank line here.

Comments should almost always be complete sentences and they should begin with a capital.

Blank line between these.

You should be building the URL using reverse(). Same elsewhere.

Missing docstring. This test is gigantic and should be split up into multiple tests.

datetime is a python stdlib import.

Move the comment into the docstring.

Blank line between these.

Blank line between these.

Col: 80 E501 line too long (89 > 79 characters)

Col: 80 E501 line too long (89 > 79 characters)

Col: 80 E501 line too long (89 > 79 characters)

Col: 80 E501 line too long (92 > 79 characters)

Col: 89 E226 missing whitespace around arithmetic operator

Col: 80 E501 line too long (80 > 79 characters)

Col: 80 E501 line too long (80 > 79 characters)

Col: 80 E501 line too long (80 > 79 characters)

Col: 80 E501 line too long (80 > 79 characters)

Col: 5 E303 too many blank lines (3)