Add a link in the repository config page for editing hosting credentials.

Review Request #8464 — Created Oct. 16, 2016 and submitted

chipx86
Review Board
release-2.5.x
f287aa5...
reviewboard
Credentials for hosting service accounts don't change very often, but
when they do, we don't provide any sane way of resetting/editing them.
The workaround before was to nuke the account data in the database
editor and then re-edit a repository, but this was pretty terrible.

We now have an "Edit credentials" link next to the selected account in
the repository configuration form. When clicked, the auth form will
appear, allowing the user to provide new credentials to use.

The user can cancel editing, or they can save the repository to
re-authenticate.

Tested saving new credentials for an account.

Tested attempting to save bad new credentials, and seeing the error
message (with the form staying open).

Tested saving new credentials that then required a 2FA token (with the
form staying open).

Tested canceling edit.

Tested edit mode and then switching accounts/services.

Loading file attachments...

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/admin.py
        reviewboard/hostingsvcs/forms.py
        reviewboard/scmtools/forms.py
    
    Ignored Files:
        reviewboard/static/rb/css/pages/admin.less
        reviewboard/static/rb/css/ui/forms.less
        reviewboard/static/rb/js/admin/repositoryform.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/scmtools/admin.py
        reviewboard/hostingsvcs/forms.py
        reviewboard/scmtools/forms.py
    
    Ignored Files:
        reviewboard/static/rb/css/pages/admin.less
        reviewboard/static/rb/css/ui/forms.less
        reviewboard/static/rb/js/admin/repositoryform.js
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (5ed6bf4)
Loading...