Status integration for pull requests

Review Request #8463 — Created Oct. 16, 2016 and updated

finaiized
Review Board
dvcs
8547
57d2e73...
reviewboard, students

Adds support for setting statuses on pull requests.

When a new pull request is created, and that repository is linked to a RB webhook, a new corresponding review request will be created. That will automatically set the pending status for the pull request.

Whenever an issue is open on the review request, the status is set to "error".
When the review request is "approved" (defaulting to 1+ ship it's and no open issues), the status is set to "success".
Otherwise, the PR has a "pending" status.

  • Added unit tests
    • to verify the pull request hook is called, and only works with pull_request events and the right signature
    • to verify pull requests are created and updated when a pull request is created
    • to verify the pull request's status starts off with 'pending', is 'error' when there's open issues, and 'success' when approved

  • Manual testing
    • Created a pull request on a repository linked to ReviewBoard through webhooks
    • Verified the review request was created with 'pending' status
    • Verified that opening an issue on the review request sets the 'error' status on the pull request
    • Verified that having no open issue and adding a 'Ship it!' sets the 'success' status on the pull request
Description From Last Updated

'ipdb' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (82 > 79 characters)

reviewbotreviewbot

local variable 'e' is assigned to but never used

reviewbotreviewbot

Col: 80 E501 line too long (100 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (112 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

'ipdb' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (84 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (82 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (97 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (82 > 79 characters)

reviewbotreviewbot

local variable 'e' is assigned to but never used

reviewbotreviewbot

Col: 80 E501 line too long (100 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (100 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (99 > 79 characters)

reviewbotreviewbot

'ipdb' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (84 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (82 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (97 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (82 > 79 characters)

reviewbotreviewbot

local variable 'e' is assigned to but never used

reviewbotreviewbot

Col: 80 E501 line too long (100 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (100 > 79 characters)

reviewbotreviewbot

local variable 'pull_request_id' is assigned to but never used

reviewbotreviewbot

Col: 80 E501 line too long (108 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 9 E266 too many leading '#' for block comment

reviewbotreviewbot

Col: 80 E501 line too long (100 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (99 > 79 characters)

reviewbotreviewbot

'ipdb' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (84 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (82 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (97 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (82 > 79 characters)

reviewbotreviewbot

local variable 'e' is assigned to but never used

reviewbotreviewbot

Col: 80 E501 line too long (100 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (100 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 9 E266 too many leading '#' for block comment

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (100 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (108 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (181 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (99 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

'ipdb' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (84 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (82 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (97 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (82 > 79 characters)

reviewbotreviewbot

local variable 'e' is assigned to but never used

reviewbotreviewbot

Col: 80 E501 line too long (100 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (100 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (100 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (108 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (181 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (99 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (98 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (100 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (82 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (97 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (82 > 79 characters)

reviewbotreviewbot

local variable 'e' is assigned to but never used

reviewbotreviewbot

Col: 80 E501 line too long (100 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (100 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (100 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (108 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (181 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (111 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (99 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (100 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (111 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (99 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Undo this.

brenniebrennie

alphabetical order - i believe this should be on line 13

LA larmiej

doc string

LA larmiej

Full path

brenniebrennie

Blank line between these. Same below. Also the docs for this param are insufficient.

brenniebrennie

unicode

brenniebrennie

unicode

brenniebrennie

unicode. No Optional

brenniebrennie

totally up to you to implement, but i will suggest that you can have something like this states = ['pending', ...

LA larmiej

Docstrings of the form: """Single line summary mutli-line description. """

brenniebrennie

Docstring must be in the imperitive (i.e., "Return") mood.

brenniebrennie

client.

brenniebrennie

Use % formatting.

brenniebrennie

function doc string

LA larmiej

Put this inside the if. Missing a period.

brenniebrennie

Pyt this inside the elif. Missing a period. A semicolon doesn't work here, either.

brenniebrennie

Single quotes here and throughout.

brenniebrennie

Should be alphabetical. Above from reviewboard.scmtools.core import Branch, Commit

CO Connor-Y

Extra line, delete this.

CO Connor-Y

I think this function needs more docstring info (Args, Returns...)

ST stensby

Should this TODO should be done/removed?

ST stensby

Should this TODO be done/removed?

ST stensby

Extra line here.

CO Connor-Y

i believe this should be review_request (reviewboard.scmtools.models.ReviewRequest): except this is different

LA larmiej

'Review' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Imperative mode, Return rather than Returns. I always make a mistake with this one, very tricky

LA larmiej

'Review' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

'Review' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/hostingsvcs/github.py
        reviewboard/reviews/models/review_request.py
        reviewboard/hostingsvcs/service.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/hostingsvcs/github.py
        reviewboard/reviews/models/review_request.py
        reviewboard/hostingsvcs/service.py
    
    
  2. reviewboard/hostingsvcs/github.py (Diff revision 1)
     
     
     'ipdb' imported but unused
    
  3. reviewboard/hostingsvcs/github.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (82 > 79 characters)
    
  4. reviewboard/hostingsvcs/github.py (Diff revision 1)
     
     
     local variable 'e' is assigned to but never used
    
  5. reviewboard/hostingsvcs/github.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (100 > 79 characters)
    
  6. reviewboard/hostingsvcs/github.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (112 > 79 characters)
    
  7. reviewboard/reviews/builtin_fields.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  8. 
      
FI
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/hostingsvcs/github.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/hostingsvcs/github.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
    
    
  2. reviewboard/hostingsvcs/github.py (Diff revision 2)
     
     
     'ipdb' imported but unused
    
  3. reviewboard/hostingsvcs/github.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (84 > 79 characters)
    
  4. reviewboard/hostingsvcs/github.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (82 > 79 characters)
    
  5. reviewboard/hostingsvcs/github.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (97 > 79 characters)
    
  6. reviewboard/hostingsvcs/github.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (94 > 79 characters)
    
  7. reviewboard/hostingsvcs/github.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (82 > 79 characters)
    
  8. reviewboard/hostingsvcs/github.py (Diff revision 2)
     
     
     local variable 'e' is assigned to but never used
    
  9. reviewboard/hostingsvcs/github.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (100 > 79 characters)
    
  10. reviewboard/hostingsvcs/github.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (100 > 79 characters)
    
  11. reviewboard/hostingsvcs/service.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  12. reviewboard/reviews/builtin_fields.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  13. reviewboard/reviews/models/review.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (99 > 79 characters)
    
  14. 
      
FI
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/hostingsvcs/github.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/hostingsvcs/github.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
    
    
  2. reviewboard/hostingsvcs/github.py (Diff revision 3)
     
     
     'ipdb' imported but unused
    
  3. reviewboard/hostingsvcs/github.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (84 > 79 characters)
    
  4. reviewboard/hostingsvcs/github.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (82 > 79 characters)
    
  5. reviewboard/hostingsvcs/github.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (97 > 79 characters)
    
  6. reviewboard/hostingsvcs/github.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (94 > 79 characters)
    
  7. reviewboard/hostingsvcs/github.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (82 > 79 characters)
    
  8. reviewboard/hostingsvcs/github.py (Diff revision 3)
     
     
     local variable 'e' is assigned to but never used
    
  9. reviewboard/hostingsvcs/github.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (100 > 79 characters)
    
  10. reviewboard/hostingsvcs/github.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (100 > 79 characters)
    
  11. reviewboard/hostingsvcs/github.py (Diff revision 3)
     
     
     local variable 'pull_request_id' is assigned to but never used
    
  12. reviewboard/hostingsvcs/github.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (108 > 79 characters)
    
  13. reviewboard/hostingsvcs/github.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (85 > 79 characters)
    
  14. reviewboard/hostingsvcs/github.py (Diff revision 3)
     
     
    Col: 9
     E266 too many leading '#' for block comment
    
  15. reviewboard/hostingsvcs/github.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (100 > 79 characters)
    
  16. reviewboard/hostingsvcs/service.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  17. reviewboard/reviews/builtin_fields.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  18. reviewboard/reviews/models/review.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (99 > 79 characters)
    
  19. 
      
FI
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
  2. reviewboard/hostingsvcs/github.py (Diff revision 4)
     
     
     'ipdb' imported but unused
    
  3. reviewboard/hostingsvcs/github.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (84 > 79 characters)
    
  4. reviewboard/hostingsvcs/github.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (82 > 79 characters)
    
  5. reviewboard/hostingsvcs/github.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (97 > 79 characters)
    
  6. reviewboard/hostingsvcs/github.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (94 > 79 characters)
    
  7. reviewboard/hostingsvcs/github.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (82 > 79 characters)
    
  8. reviewboard/hostingsvcs/github.py (Diff revision 4)
     
     
     local variable 'e' is assigned to but never used
    
  9. reviewboard/hostingsvcs/github.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (100 > 79 characters)
    
  10. reviewboard/hostingsvcs/github.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (115 > 79 characters)
    
  11. reviewboard/hostingsvcs/github.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (100 > 79 characters)
    
  12. reviewboard/hostingsvcs/github.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (94 > 79 characters)
    
  13. reviewboard/hostingsvcs/github.py (Diff revision 4)
     
     
    Col: 9
     E266 too many leading '#' for block comment
    
  14. reviewboard/hostingsvcs/github.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (115 > 79 characters)
    
  15. reviewboard/hostingsvcs/github.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (100 > 79 characters)
    
  16. reviewboard/hostingsvcs/service.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  17. reviewboard/reviews/builtin_fields.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  18. Col: 80
     E501 line too long (108 > 79 characters)
    
  19. Col: 80
     E501 line too long (181 > 79 characters)
    
  20. reviewboard/reviews/models/review.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (99 > 79 characters)
    
  21. Col: 80
     E501 line too long (87 > 79 characters)
    
  22. 
      
FI
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
  2. reviewboard/hostingsvcs/github.py (Diff revision 5)
     
     
     'ipdb' imported but unused
    
  3. reviewboard/hostingsvcs/github.py (Diff revision 5)
     
     
    Col: 80
     E501 line too long (84 > 79 characters)
    
  4. reviewboard/hostingsvcs/github.py (Diff revision 5)
     
     
    Col: 80
     E501 line too long (82 > 79 characters)
    
  5. reviewboard/hostingsvcs/github.py (Diff revision 5)
     
     
    Col: 80
     E501 line too long (97 > 79 characters)
    
  6. reviewboard/hostingsvcs/github.py (Diff revision 5)
     
     
    Col: 80
     E501 line too long (94 > 79 characters)
    
  7. reviewboard/hostingsvcs/github.py (Diff revision 5)
     
     
    Col: 80
     E501 line too long (82 > 79 characters)
    
  8. reviewboard/hostingsvcs/github.py (Diff revision 5)
     
     
     local variable 'e' is assigned to but never used
    
  9. reviewboard/hostingsvcs/github.py (Diff revision 5)
     
     
    Col: 80
     E501 line too long (100 > 79 characters)
    
  10. reviewboard/hostingsvcs/github.py (Diff revision 5)
     
     
    Col: 80
     E501 line too long (115 > 79 characters)
    
  11. reviewboard/hostingsvcs/github.py (Diff revision 5)
     
     
    Col: 80
     E501 line too long (100 > 79 characters)
    
  12. reviewboard/hostingsvcs/github.py (Diff revision 5)
     
     
    Col: 80
     E501 line too long (94 > 79 characters)
    
  13. reviewboard/hostingsvcs/github.py (Diff revision 5)
     
     
    Col: 80
     E501 line too long (115 > 79 characters)
    
  14. reviewboard/hostingsvcs/github.py (Diff revision 5)
     
     
    Col: 80
     E501 line too long (100 > 79 characters)
    
  15. reviewboard/hostingsvcs/service.py (Diff revision 5)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  16. reviewboard/reviews/builtin_fields.py (Diff revision 5)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  17. Col: 80
     E501 line too long (108 > 79 characters)
    
  18. Col: 80
     E501 line too long (181 > 79 characters)
    
  19. reviewboard/reviews/models/review.py (Diff revision 5)
     
     
    Col: 80
     E501 line too long (99 > 79 characters)
    
  20. Col: 80
     E501 line too long (87 > 79 characters)
    
  21. 
      
FI
FI
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
  2. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 80
     E501 line too long (98 > 79 characters)
    
  3. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 80
     E501 line too long (100 > 79 characters)
    
  4. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 80
     E501 line too long (82 > 79 characters)
    
  5. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 80
     E501 line too long (97 > 79 characters)
    
  6. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 80
     E501 line too long (94 > 79 characters)
    
  7. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 80
     E501 line too long (82 > 79 characters)
    
  8. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
     local variable 'e' is assigned to but never used
    
  9. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 80
     E501 line too long (100 > 79 characters)
    
  10. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 80
     E501 line too long (115 > 79 characters)
    
  11. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 80
     E501 line too long (100 > 79 characters)
    
  12. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 80
     E501 line too long (94 > 79 characters)
    
  13. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 80
     E501 line too long (115 > 79 characters)
    
  14. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 80
     E501 line too long (100 > 79 characters)
    
  15. reviewboard/hostingsvcs/service.py (Diff revision 6)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  16. reviewboard/reviews/builtin_fields.py (Diff revision 6)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  17. Col: 80
     E501 line too long (108 > 79 characters)
    
  18. Col: 80
     E501 line too long (181 > 79 characters)
    
  19. Col: 80
     E501 line too long (111 > 79 characters)
    
  20. reviewboard/reviews/models/review.py (Diff revision 6)
     
     
    Col: 80
     E501 line too long (99 > 79 characters)
    
  21. Col: 80
     E501 line too long (87 > 79 characters)
    
  22. 
      
FI
FI
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
  2. reviewboard/hostingsvcs/github.py (Diff revision 7)
     
     
    Col: 80
     E501 line too long (80 > 79 characters)
    
  3. reviewboard/hostingsvcs/github.py (Diff revision 7)
     
     
    Col: 80
     E501 line too long (94 > 79 characters)
    
  4. reviewboard/hostingsvcs/github.py (Diff revision 7)
     
     
    Col: 80
     E501 line too long (115 > 79 characters)
    
  5. reviewboard/hostingsvcs/github.py (Diff revision 7)
     
     
    Col: 80
     E501 line too long (100 > 79 characters)
    
  6. Col: 80
     E501 line too long (111 > 79 characters)
    
  7. reviewboard/reviews/models/review.py (Diff revision 7)
     
     
    Col: 80
     E501 line too long (99 > 79 characters)
    
  8. Col: 80
     E501 line too long (87 > 79 characters)
    
  9. 
      
FI
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
  2. 
      
FI
FI
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
  2. 
      
LA
  1. 
      
  2. reviewboard/hostingsvcs/github.py (Diff revision 9)
     
     

    alphabetical order - i believe this should be on line 13

  3. reviewboard/hostingsvcs/github.py (Diff revision 9)
     
     

    doc string

  4. reviewboard/hostingsvcs/github.py (Diff revision 9)
     
     

    totally up to you to implement, but i will suggest that you can have something like this

    states = ['pending', 'success', 'error', 'failure']
    
    if state not in states:
       raise ValueError
    
    1. That's definitely cleaner, thanks!

  5. reviewboard/hostingsvcs/github.py (Diff revision 9)
     
     

    function doc string

  6. 
      
brennie
  1. 
      
  2. reviewboard/hostingsvcs/github.py (Diff revision 9)
     
     

    Undo this.

  3. reviewboard/hostingsvcs/github.py (Diff revision 9)
     
     
     

    Full path

  4. reviewboard/hostingsvcs/github.py (Diff revision 9)
     
     
     

    Blank line between these. Same below.

    Also the docs for this param are insufficient.

  5. reviewboard/hostingsvcs/github.py (Diff revision 9)
     
     

    unicode

  6. reviewboard/hostingsvcs/github.py (Diff revision 9)
     
     

    unicode

  7. reviewboard/hostingsvcs/github.py (Diff revision 9)
     
     

    unicode. No Optional

  8. reviewboard/hostingsvcs/github.py (Diff revision 9)
     
     
     

    Docstrings of the form:

    """Single line summary
    
    mutli-line description.
    """
    
  9. reviewboard/hostingsvcs/github.py (Diff revision 9)
     
     

    Docstring must be in the imperitive (i.e., "Return") mood.

  10. reviewboard/hostingsvcs/github.py (Diff revision 9)
     
     

    client.

  11. reviewboard/hostingsvcs/github.py (Diff revision 9)
     
     

    Use % formatting.

  12. reviewboard/hostingsvcs/github.py (Diff revision 9)
     
     

    Put this inside the if. Missing a period.

  13. reviewboard/hostingsvcs/github.py (Diff revision 9)
     
     

    Pyt this inside the elif. Missing a period. A semicolon doesn't work here, either.

  14. reviewboard/hostingsvcs/github.py (Diff revision 9)
     
     

    Single quotes here and throughout.

  15. 
      
FI
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
  2. 
      
ST
  1. 
      
  2. reviewboard/hostingsvcs/github.py (Diff revision 10)
     
     
    I think this function needs more docstring info (Args, Returns...)
  3. reviewboard/hostingsvcs/github.py (Diff revision 10)
     
     
    Should this TODO should be done/removed?
    1. I'm going to leave the TODOs in for now. I think it's a bit clearer since the work still needs to be done.

  4. reviewboard/hostingsvcs/github.py (Diff revision 10)
     
     
    Should this TODO be done/removed?
  5. 
      
CO
  1. 
      
  2. reviewboard/hostingsvcs/github.py (Diff revision 10)
     
     

    Should be alphabetical.
    Above from reviewboard.scmtools.core import Branch, Commit

  3. reviewboard/hostingsvcs/github.py (Diff revision 10)
     
     

    Extra line, delete this.

  4. reviewboard/hostingsvcs/github.py (Diff revision 10)
     
     

    Extra line here.

  5. 
      
FI
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/hostingsvcs/tests/test_github.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/hostingsvcs/tests/test_github.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
  2. 
      
FI
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/hostingsvcs/tests/test_github.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/hostingsvcs/tests/test_github.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
  2.  'Review' imported but unused
    
  3. Col: 80
     E501 line too long (80 > 79 characters)
    
  4. 
      
LA
  1. 
      
  2. reviewboard/hostingsvcs/github.py (Diff revision 12)
     
     

    not necessary to implement, you can have constants for the status because I see you used them again in the next method and they may used again with new addition of code later in the future.

  3. reviewboard/hostingsvcs/service.py (Diff revision 12)
     
     

    i believe this should be
    review_request (reviewboard.scmtools.models.ReviewRequest):

    except this is different

  4. Imperative mode, Return rather than Returns. I always make a mistake with this one, very tricky

    1. I've heard this too, but every comment in this file uses "Returns". Not sure if this is just some "old-style" commenting and should be updated everywhere.

    2. I'm honestly not sure, but I believe with the number of reviews I have gotten reagarding the imperative mode; it is probably the new-style and i dont think you will need to update every old style instance

  5. 
      
FI
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/hostingsvcs/tests/test_github.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/hostingsvcs/tests/test_github.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
  2.  'Review' imported but unused
    
  3. Col: 80
     E501 line too long (80 > 79 characters)
    
  4. 
      
FI
FI
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/hostingsvcs/tests/test_github.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/hostingsvcs/tests/test_github.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
  2.  'Review' imported but unused
    
  3. Col: 80
     E501 line too long (80 > 79 characters)
    
  4. 
      
FI
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/hostingsvcs/tests/test_github.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/hostingsvcs/tests/test_github.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
    
    
  2. 
      
FI
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/hostingsvcs/tests/test_github.py
        reviewboard/diffviewer/diffutils.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
        reviewboard/reviews/models/review_request.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/hostingsvcs/tests/test_github.py
        reviewboard/diffviewer/diffutils.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
        reviewboard/reviews/models/review_request.py
    
    
  2. reviewboard/hostingsvcs/github.py (Diff revision 16)
     
     
    Col: 80
     E501 line too long (80 > 79 characters)
    
  3. 
      
FI
Review request changed
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/hostingsvcs/tests/test_github.py
        reviewboard/diffviewer/diffutils.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
        reviewboard/reviews/models/review_request.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/hostingsvcs/tests/test_github.py
        reviewboard/diffviewer/diffutils.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/models/review.py
        reviewboard/hostingsvcs/service.py
        reviewboard/hostingsvcs/github.py
        reviewboard/reviews/models/review_request.py
    
    
  2. 
      
Loading...