-
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 1) local variable 'e' is assigned to but never used
-
reviewboard/hostingsvcs/github.py (Diff revision 1) Col: 80 E501 line too long (100 > 79 characters)
-
reviewboard/hostingsvcs/github.py (Diff revision 1) Col: 80 E501 line too long (112 > 79 characters)
-
reviewboard/reviews/builtin_fields.py (Diff revision 1) Col: 80 E501 line too long (81 > 79 characters)
Status integration for pull requests
Review Request #8463 — Created Oct. 16, 2016 and discarded
| Information | |
|---|---|
| finaiized | |
| Review Board | |
| dvcs | |
| 8547 | |
| Reviewers | |
| reviewboard, students | |
Adds support for setting statuses on pull requests.
When a new pull request is created, and that repository is linked to a RB webhook, a new corresponding review request will be created. That will automatically set the pending status for the pull request.
Whenever an issue is open on the review request, the status is set to "error".
When the review request is "approved" (defaulting to 1+ ship it's and no open issues), the status is set to "success".
Otherwise, the PR has a "pending" status.
- Added unit tests
- to verify the pull request hook is called, and only works with
pull_requestevents and the right signature - to verify pull requests are created and updated when a pull request is created
- to verify the pull request's status starts off with 'pending', is 'error' when there's open issues, and 'success' when approved
- to verify the pull request hook is called, and only works with
- Manual testing
- Created a pull request on a repository linked to ReviewBoard through webhooks
- Verified the review request was created with 'pending' status
- Verified that opening an issue on the review request sets the 'error' status on the pull request
- Verified that having no open issue and adding a 'Ship it!' sets the 'success' status on the pull request
| Description | From | Last Updated |
|---|---|---|
|
'ipdb' imported but unused |
 reviewbot
|
|
|
Col: 80 E501 line too long (82 > 79 characters) |
reviewbot
|
|
|
local variable 'e' is assigned to but never used |
reviewbot
|
|
|
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (112 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
'ipdb' imported but unused |
reviewbot
|
|
|
Col: 80 E501 line too long (84 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (82 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (97 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (94 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (82 > 79 characters) |
reviewbot
|
|
|
local variable 'e' is assigned to but never used |
reviewbot
|
|
|
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (89 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (99 > 79 characters) |
reviewbot
|
|
|
'ipdb' imported but unused |
reviewbot
|
|
|
Col: 80 E501 line too long (84 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (82 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (97 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (94 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (82 > 79 characters) |
reviewbot
|
|
|
local variable 'e' is assigned to but never used |
reviewbot
|
|
|
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot
|
|
|
local variable 'pull_request_id' is assigned to but never used |
reviewbot
|
|
|
Col: 80 E501 line too long (108 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (85 > 79 characters) |
reviewbot
|
|
|
Col: 9 E266 too many leading '#' for block comment |
reviewbot
|
|
|
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (89 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (99 > 79 characters) |
reviewbot
|
|
|
'ipdb' imported but unused |
reviewbot
|
|
|
Col: 80 E501 line too long (84 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (82 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (97 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (94 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (82 > 79 characters) |
reviewbot
|
|
|
local variable 'e' is assigned to but never used |
reviewbot
|
|
|
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (115 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (94 > 79 characters) |
reviewbot
|
|
|
Col: 9 E266 too many leading '#' for block comment |
reviewbot
|
|
|
Col: 80 E501 line too long (115 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (89 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (108 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (181 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (99 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (87 > 79 characters) |
reviewbot
|
|
|
'ipdb' imported but unused |
reviewbot
|
|
|
Col: 80 E501 line too long (84 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (82 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (97 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (94 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (82 > 79 characters) |
reviewbot
|
|
|
local variable 'e' is assigned to but never used |
reviewbot
|
|
|
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (115 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (94 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (115 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (89 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (108 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (181 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (99 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (87 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (98 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (82 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (97 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (94 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (82 > 79 characters) |
reviewbot
|
|
|
local variable 'e' is assigned to but never used |
reviewbot
|
|
|
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (115 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (94 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (115 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (89 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (108 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (181 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (111 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (99 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (87 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (94 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (115 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (111 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (99 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (87 > 79 characters) |
reviewbot
|
|
|
Undo this. |
 brennie
|
|
|
alphabetical order - i believe this should be on line 13 |
LA larmiej | |
|
doc string |
LA larmiej | |
|
Full path |
brennie
|
|
|
Blank line between these. Same below. Also the docs for this param are insufficient. |
brennie
|
|
|
unicode |
brennie
|
|
|
unicode |
brennie
|
|
|
unicode. No Optional |
brennie
|
|
|
totally up to you to implement, but i will suggest that you can have something like this states = ['pending', … |
LA larmiej | |
|
Docstrings of the form: """Single line summary mutli-line description. """ |
brennie
|
|
|
Docstring must be in the imperitive (i.e., "Return") mood. |
brennie
|
|
|
client. |
brennie
|
|
|
Use % formatting. |
brennie
|
|
|
function doc string |
LA larmiej | |
|
Put this inside the if. Missing a period. |
brennie
|
|
|
Pyt this inside the elif. Missing a period. A semicolon doesn't work here, either. |
brennie
|
|
|
Single quotes here and throughout. |
brennie
|
|
|
Should be alphabetical. Above from reviewboard.scmtools.core import Branch, Commit |
CO Connor-Y | |
|
Extra line, delete this. |
CO Connor-Y | |
|
I think this function needs more docstring info (Args, Returns...) |
ST stensby | |
|
Should this TODO should be done/removed? |
ST stensby | |
|
Should this TODO be done/removed? |
ST stensby | |
|
Extra line here. |
CO Connor-Y | |
|
i believe this should be review_request (reviewboard.scmtools.models.ReviewRequest): except this is different |
LA larmiej | |
|
'Review' imported but unused |
reviewbot
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
Imperative mode, Return rather than Returns. I always make a mistake with this one, very tricky |
LA larmiej | |
|
'Review' imported but unused |
reviewbot
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
'Review' imported but unused |
reviewbot
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot
|
FI
Change Summary:
Update pull request status every time a review request has a new review posted.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+173 -5) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/builtin_fields.py reviewboard/hostingsvcs/github.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/builtin_fields.py reviewboard/hostingsvcs/github.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py -
-
-
-
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 2) local variable 'e' is assigned to but never used
-
reviewboard/hostingsvcs/github.py (Diff revision 2) Col: 80 E501 line too long (100 > 79 characters)
-
reviewboard/hostingsvcs/github.py (Diff revision 2) Col: 80 E501 line too long (100 > 79 characters)
-
reviewboard/hostingsvcs/service.py (Diff revision 2) Col: 80 E501 line too long (89 > 79 characters)
-
reviewboard/reviews/builtin_fields.py (Diff revision 2) Col: 80 E501 line too long (81 > 79 characters)
-
reviewboard/reviews/models/review.py (Diff revision 2) Col: 80 E501 line too long (99 > 79 characters)
FI
Change Summary:
Add diffset when creating a new review request from a PR
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+191 -5) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/builtin_fields.py reviewboard/hostingsvcs/github.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/builtin_fields.py reviewboard/hostingsvcs/github.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py -
-
-
-
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 3) local variable 'e' is assigned to but never used
-
reviewboard/hostingsvcs/github.py (Diff revision 3) Col: 80 E501 line too long (100 > 79 characters)
-
reviewboard/hostingsvcs/github.py (Diff revision 3) Col: 80 E501 line too long (100 > 79 characters)
-
reviewboard/hostingsvcs/github.py (Diff revision 3) local variable 'pull_request_id' is assigned to but never used
-
reviewboard/hostingsvcs/github.py (Diff revision 3) Col: 80 E501 line too long (108 > 79 characters)
-
-
reviewboard/hostingsvcs/github.py (Diff revision 3) Col: 9 E266 too many leading '#' for block comment
-
reviewboard/hostingsvcs/github.py (Diff revision 3) Col: 80 E501 line too long (100 > 79 characters)
-
reviewboard/hostingsvcs/service.py (Diff revision 3) Col: 80 E501 line too long (89 > 79 characters)
-
reviewboard/reviews/builtin_fields.py (Diff revision 3) Col: 80 E501 line too long (81 > 79 characters)
-
reviewboard/reviews/models/review.py (Diff revision 3) Col: 80 E501 line too long (99 > 79 characters)
FI
Change Summary:
- Moved the pull request ID from being in
extra_datato a property ofReviewRequestto support querying, along with the corresponding evolution. - Updated implementation of generating diffsets from pull requests based on feedback.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+211 -6) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/evolutions/__init__.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/evolutions/__init__.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py -
-
-
-
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 4) local variable 'e' is assigned to but never used
-
reviewboard/hostingsvcs/github.py (Diff revision 4) Col: 80 E501 line too long (100 > 79 characters)
-
reviewboard/hostingsvcs/github.py (Diff revision 4) Col: 80 E501 line too long (115 > 79 characters)
-
reviewboard/hostingsvcs/github.py (Diff revision 4) Col: 80 E501 line too long (100 > 79 characters)
-
-
reviewboard/hostingsvcs/github.py (Diff revision 4) Col: 9 E266 too many leading '#' for block comment
-
reviewboard/hostingsvcs/github.py (Diff revision 4) Col: 80 E501 line too long (115 > 79 characters)
-
reviewboard/hostingsvcs/github.py (Diff revision 4) Col: 80 E501 line too long (100 > 79 characters)
-
reviewboard/hostingsvcs/service.py (Diff revision 4) Col: 80 E501 line too long (89 > 79 characters)
-
reviewboard/reviews/builtin_fields.py (Diff revision 4) Col: 80 E501 line too long (81 > 79 characters)
-
reviewboard/reviews/evolutions/pull_request.py (Diff revision 4) Col: 80 E501 line too long (108 > 79 characters)
-
reviewboard/reviews/evolutions/pull_request.py (Diff revision 4) Col: 80 E501 line too long (181 > 79 characters)
-
reviewboard/reviews/models/review.py (Diff revision 4) Col: 80 E501 line too long (99 > 79 characters)
-
reviewboard/reviews/models/review_request.py (Diff revision 4) Col: 80 E501 line too long (87 > 79 characters)
FI
Change Summary:
Code cleanup; add hook authentication; change status integration API call method
Branch: |
|
||||
|---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 5 (+214 -18) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/evolutions/__init__.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/evolutions/__init__.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py -
-
-
-
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 5) local variable 'e' is assigned to but never used
-
reviewboard/hostingsvcs/github.py (Diff revision 5) Col: 80 E501 line too long (100 > 79 characters)
-
reviewboard/hostingsvcs/github.py (Diff revision 5) Col: 80 E501 line too long (115 > 79 characters)
-
reviewboard/hostingsvcs/github.py (Diff revision 5) Col: 80 E501 line too long (100 > 79 characters)
-
-
reviewboard/hostingsvcs/github.py (Diff revision 5) Col: 80 E501 line too long (115 > 79 characters)
-
reviewboard/hostingsvcs/github.py (Diff revision 5) Col: 80 E501 line too long (100 > 79 characters)
-
reviewboard/hostingsvcs/service.py (Diff revision 5) Col: 80 E501 line too long (89 > 79 characters)
-
reviewboard/reviews/builtin_fields.py (Diff revision 5) Col: 80 E501 line too long (81 > 79 characters)
-
reviewboard/reviews/evolutions/pull_request.py (Diff revision 5) Col: 80 E501 line too long (108 > 79 characters)
-
reviewboard/reviews/evolutions/pull_request.py (Diff revision 5) Col: 80 E501 line too long (181 > 79 characters)
-
reviewboard/reviews/models/review.py (Diff revision 5) Col: 80 E501 line too long (99 > 79 characters)
-
reviewboard/reviews/models/review_request.py (Diff revision 5) Col: 80 E501 line too long (87 > 79 characters)
FI
Change Summary:
- Finish implementing Github API's status call with documentation
- Update PR status when inline issues are dropped/fixed
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 6 (+236 -20) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py -
-
reviewboard/hostingsvcs/github.py (Diff revision 6) Col: 80 E501 line too long (100 > 79 characters)
-
-
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 6) local variable 'e' is assigned to but never used
-
reviewboard/hostingsvcs/github.py (Diff revision 6) Col: 80 E501 line too long (100 > 79 characters)
-
reviewboard/hostingsvcs/github.py (Diff revision 6) Col: 80 E501 line too long (115 > 79 characters)
-
reviewboard/hostingsvcs/github.py (Diff revision 6) Col: 80 E501 line too long (100 > 79 characters)
-
-
reviewboard/hostingsvcs/github.py (Diff revision 6) Col: 80 E501 line too long (115 > 79 characters)
-
reviewboard/hostingsvcs/github.py (Diff revision 6) Col: 80 E501 line too long (100 > 79 characters)
-
reviewboard/hostingsvcs/service.py (Diff revision 6) Col: 80 E501 line too long (89 > 79 characters)
-
reviewboard/reviews/builtin_fields.py (Diff revision 6) Col: 80 E501 line too long (81 > 79 characters)
-
reviewboard/reviews/evolutions/pull_request.py (Diff revision 6) Col: 80 E501 line too long (108 > 79 characters)
-
reviewboard/reviews/evolutions/pull_request.py (Diff revision 6) Col: 80 E501 line too long (181 > 79 characters)
-
reviewboard/reviews/models/base_comment.py (Diff revision 6) Col: 80 E501 line too long (111 > 79 characters)
-
reviewboard/reviews/models/review.py (Diff revision 6) Col: 80 E501 line too long (99 > 79 characters)
-
reviewboard/reviews/models/review_request.py (Diff revision 6) Col: 80 E501 line too long (87 > 79 characters)
FI
Change Summary:
Updated description to cover scenarios.
Description: |
|
|---|
FI
Change Summary:
Deal with Reviewbot warnings.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 7 (+249 -20) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py -
-
-
reviewboard/hostingsvcs/github.py (Diff revision 7) Col: 80 E501 line too long (115 > 79 characters)
-
reviewboard/hostingsvcs/github.py (Diff revision 7) Col: 80 E501 line too long (100 > 79 characters)
-
reviewboard/reviews/models/base_comment.py (Diff revision 7) Col: 80 E501 line too long (111 > 79 characters)
-
reviewboard/reviews/models/review.py (Diff revision 7) Col: 80 E501 line too long (99 > 79 characters)
-
reviewboard/reviews/models/review_request.py (Diff revision 7) Col: 80 E501 line too long (87 > 79 characters)
FI
Change Summary:
Deal with Reviewbot warnings, round 2.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 8 (+254 -20) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py
FI
Change Summary:
Removed an extra print and TODO
Branch: |
|
||||
|---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 9 (+251 -20) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py
LA
-
-
reviewboard/hostingsvcs/github.py (Diff revision 9) alphabetical order - i believe this should be on
line 13 -
-
reviewboard/hostingsvcs/github.py (Diff revision 9) totally up to you to implement, but i will suggest that you can have something like this
states = ['pending', 'success', 'error', 'failure'] if state not in states: raise ValueError -
-
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 9) Blank line between these. Same below.
Also the docs for this param are insufficient.
-
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 9) Docstrings of the form:
"""Single line summary mutli-line description. """ -
reviewboard/hostingsvcs/github.py (Diff revision 9) Docstring must be in the imperitive (i.e., "Return") mood.
-
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 9) Pyt this inside the
elif. Missing a period. A semicolon doesn't work here, either. -
FI
Change Summary:
Various fixes as suggested by reviews.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 10 (+246 -19) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py
ST
-
-
reviewboard/hostingsvcs/github.py (Diff revision 10) I think this function needs more docstring info (Args, Returns...)
-
-
CO
-
-
reviewboard/hostingsvcs/github.py (Diff revision 10) Should be alphabetical.
Abovefrom reviewboard.scmtools.core import Branch, Commit -
-
FI
Change Summary:
- Add preliminary test suite
- Documentation updates
- Fixes for issues on this review
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 11 (+493 -19) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/hostingsvcs/tests/test_github.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/hostingsvcs/tests/test_github.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py
FI
Change Summary:
- Refactored tests
- Add tests specifically for status changes
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 12 (+512 -20) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/hostingsvcs/tests/test_github.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/hostingsvcs/tests/test_github.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py -
-
reviewboard/hostingsvcs/tests/test_github.py (Diff revision 12) Col: 80 E501 line too long (80 > 79 characters)
LA
-
-
reviewboard/hostingsvcs/github.py (Diff revision 12) not necessary to implement, you can have constants for the status because I see you used them again in the next method and they may used again with new addition of code later in the future.
-
reviewboard/hostingsvcs/service.py (Diff revision 12) i believe this should be
review_request (reviewboard.scmtools.models.ReviewRequest):except this is different
-
reviewboard/reviews/models/review_request.py (Diff revision 12) Imperative mode,
Returnrather than Returns. I always make a mistake with this one, very tricky
FI
Change Summary:
- Fixes issue where the pull request hook didn't verify its sender
- Add test for verifying pull request hook's sender
- Updated "Testing Done" section
Testing Done: |
|
|||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||||||||||||||||||||
Diff: |
Revision 13 (+534 -20) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/hostingsvcs/tests/test_github.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/hostingsvcs/tests/test_github.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py -
-
reviewboard/hostingsvcs/tests/test_github.py (Diff revision 13) Col: 80 E501 line too long (80 > 79 characters)
FI
Change Summary:
Formatting
Testing Done: |
|
|---|
FI
Change Summary:
- Fully qualify type in doc comment
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 14 (+534 -20) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/hostingsvcs/tests/test_github.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/hostingsvcs/tests/test_github.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py -
-
reviewboard/hostingsvcs/tests/test_github.py (Diff revision 14) Col: 80 E501 line too long (80 > 79 characters)
FI
Change Summary:
Fix reviewbot issues
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 15 (+533 -19) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/hostingsvcs/tests/test_github.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/hostingsvcs/tests/test_github.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py
FI
Change Summary:
Rebase with latest changes based on reviews
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 16 (+658 -23) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/hostingsvcs/tests/test_github.py reviewboard/diffviewer/diffutils.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py reviewboard/reviews/models/review_request.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/hostingsvcs/tests/test_github.py reviewboard/diffviewer/diffutils.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py reviewboard/reviews/models/review_request.py -
reviewboard/hostingsvcs/github.py (Diff revision 16) Col: 80 E501 line too long (80 > 79 characters)
FI
Change Summary:
Fixed overrunning line
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 17 (+659 -23) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/hostingsvcs/tests/test_github.py reviewboard/diffviewer/diffutils.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py reviewboard/reviews/models/review_request.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/evolutions/pull_request.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/hostingsvcs/tests/test_github.py reviewboard/diffviewer/diffutils.py reviewboard/reviews/builtin_fields.py reviewboard/reviews/models/review.py reviewboard/hostingsvcs/service.py reviewboard/hostingsvcs/github.py reviewboard/reviews/models/review_request.py
Tool: Pyflakes Processed Files: reviewboard/reviews/builtin_fields.py reviewboard/hostingsvcs/github.py reviewboard/reviews/models/review_request.py reviewboard/hostingsvcs/service.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/builtin_fields.py reviewboard/hostingsvcs/github.py reviewboard/reviews/models/review_request.py reviewboard/hostingsvcs/service.py