Add new updates column to review request datagrid.
Review Request #8455 — Created Oct. 11, 2016 and submitted
This change adds the new updates column (
NewUpdatesColumn) to the review
request datagrid (ReviewRequestDataGrid), to make the column offerings for
this datagrid consistent with those in the dashbord datagrid.
Added New Updates column to review request datagrid for both logged in and logged out case. Updated a review request and verified that this change was reflected in the state of the column.
| Description | From | Last Updated |
|---|---|---|
|
Single quotes. Also I feel like your bit in the description should be here instead (as a comment). |
brennie
|
Review request changed
- Change Summary:
-
Addressed Barret's feedback.
- Description:
-
This change adds the new updates column (
NewUpdatesColumn) to the reviewrequest datagrid ( ReviewRequestDataGrid), to make the column offerings forthis datagrid consistent with those in the dashbord datagrid. - - In
render_data()it is necessary to verify that the review request contains- the new_review_countattribute prior to accessing the attribute, as it will- not be present in the case where the user is not logged in. - Commit:
-
1f588f9f75c6519a7da573b1e23d5334767146cebadc19fa9484a66696a89ccb91605f972ecd78d3
Tool: Pyflakes Processed Files: reviewboard/datagrids/grids.py reviewboard/datagrids/columns.py Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/grids.py reviewboard/datagrids/columns.py