Summary

Add new updates column to review request datagrid.

Review Request #8455 — Created Oct. 11, 2016 and submitted Oct. 26, 2016, 1:45 p.m.

Information

Owner

gmyers

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

badc19f...

Reviewers

Groups

reviewboard

People

Description

This change adds the new updates column (NewUpdatesColumn) to the review
request datagrid (ReviewRequestDataGrid), to make the column offerings for
this datagrid consistent with those in the dashbord datagrid.

Testing Done

Added New Updates column to review request datagrid for both logged in and 
logged out case.  Updated a review request and verified that this change was
reflected in the state of the column.

Issues

Description	From	Last Updated
Single quotes. Also I feel like your bit in the description should be here instead (as a comment).	brennie	Oct. 13, 2016, 5:58 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/columns.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/columns.py

reviewboard/datagrids/columns.py (Diff revision 1)

The issue has been resolved. Show all issues

Single quotes.

Also I feel like your bit in the description should be here instead (as a comment).

Change Summary:

Addressed Barret's feedback.

Description:

		This change adds the new updates column (`NewUpdatesColumn`) to the review
		request datagrid (`ReviewRequestDataGrid`), to make the column offerings for
		this datagrid consistent with those in the dashbord datagrid.
-
-		In `render_data()` it is necessary to verify that the review request contains
-		the `new_review_count` attribute prior to accessing the attribute, as it will
-		not be present in the case where the user is not logged in.

Commit:

-	1f588f9f75c6519a7da573b1e23d5334767146ce
+	badc19fa9484a66696a89ccb91605f972ecd78d3

Diff:

Revision 2 (+7 -1)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/datagrids/grids.py

Tool: Pyflakes
Processed Files:
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/columns.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/datagrids/grids.py
    reviewboard/datagrids/columns.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (56206d2)