Summary

Fix the links generated by the ReviewGroupUser resource

Review Request #8449 — Created Oct. 6, 2016 and submitted Oct. 12, 2016, 1:25 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.0.x

Bugs

4382

Depends On

Blocks

8458

Commit

240000f...

Reviewers

Groups

reviewboard

People

Description

Previously the links generated by the ReviewGroupUser resource
pointed at the UserResource. In other words, the delete link for the
ReviewGroupUser resource would actually be the delete link for the
UserResource and using it would result in the deletion of the user,
not the removal from review group. This was because these resources
shared a name (user) and as such, the lookups for URL names were
incorrect.

Now we correctly generate the links for the ReviewGroupUser resource.
We have added a related link to the actual user resource. Unit tests
have been added which ensure the delete links are correct in the
resources.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Missing type and explanation for this.	david	Oct. 7, 2016, 2:33 p.m.
Needs "Returns"	david	Oct. 7, 2016, 2:33 p.m.
Needs "Returns"	david	Oct. 7, 2016, 2:36 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/review_group_user.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_review_group_user.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/review_group_user.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_review_group_user.py

reviewboard/webapi/resources/review_group_user.py (Diff revision 1)
Show all issues
```
Missing type and explanation for this.
```
reviewboard/webapi/resources/review_group_user.py (Diff revision 1)
Show all issues
```
Needs "Returns"
```
reviewboard/webapi/resources/review_group_user.py (Diff revision 1)
Show all issues
```
Needs "Returns"
```

Change Summary:

Addressed David's issues

Commit:

-	ee896e3b8d998f2d789975e73dbdb9ab99e90786
+	240000fea8f30178848870da9dfd12c9d5b0e84d

Diff:

Revision 2 (+134 -10)

Show changes

	reviewboard/webapi/resources/review_group_user.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_review_group_user.py
	reviewboard/webapi/tests/urls.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/review_group_user.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_review_group_user.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/review_group_user.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_review_group_user.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (e05a6b5)