rswanson got a fish trophy!

Summary

Integrating Extension mixin in to RB root resource

Review Request #8448 — Created Sept. 29, 2016 and discarded Oct. 26, 2021, 12:16 p.m.

Information

Owner

rswanson

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

Integrating Extension mixin in to RB root resource

Testing Done

Issues

Description	From	Last Updated
You can just import this as ExtensionRootResourceMixin. There is no reason to rename it. We rename the DjbletsRootResource because otherwise …	brennie	Sept. 29, 2016, 8:37 p.m.
Must be in alphabetical order.	chipx86	Oct. 27, 2016, 5:03 p.m.
Mixins should actually go first in the list.	chipx86	Oct. 27, 2016, 5:05 p.m.
Docstring.	brennie	Oct. 27, 2016, 5:10 p.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	Oct. 27, 2016, 10:31 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Oct. 27, 2016, 10:31 p.m.
Col: 6 E128 continuation line under-indented for visual indent	reviewbot	Oct. 27, 2016, 10:31 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py



Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py

reviewboard/webapi/resources/root.py (Diff revision 1)

The issue has been resolved. Show all issues

You can just import this as ExtensionRootResourceMixin. There is no reason to rename it. We rename the DjbletsRootResource because otherwise we would be redefining RootResource.

Commit:

-	0ea8da52bbb19cc4b8a24a13526f4183861c1913
+	94803efc0896418839beade03914eb9cf93cf5b7

Diff:

Revision 2 (+6 -1)

Show changes

reviewboard/webapi/resources/root.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py



Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py

reviewboard/webapi/resources/root.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Docstring.
```

Summary:

-	[WIP] Integrating Extension mixin in to RB root resource
+	Integrating Extension mixin in to RB root resource

Description:

~		[WIP] Integrating Extension mixin in to RB root resource
	~	Integrating Extension mixin in to RB root resource

This is missing a fleshed out description and testing. I should be able to look at this change with no knowledge of what you're working on, and walk away with a good sense of why this change matters.

reviewboard/webapi/resources/root.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Must be in alphabetical order.
```
reviewboard/webapi/resources/root.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Mixins should actually go first in the list.
```

Commit:

-	94803efc0896418839beade03914eb9cf93cf5b7
+	cf98adaf55681d73ab8ec1b1a016f8948970344c

Diff:

Revision 3 (+12 -1)

Show changes

reviewboard/webapi/resources/root.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py

reviewboard/webapi/resources/root.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```
reviewboard/webapi/resources/root.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/webapi/resources/root.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 6
 E128 continuation line under-indented for visual indent
```

Commit:

-	cf98adaf55681d73ab8ec1b1a016f8948970344c
+	f8c64ce33028ee93d84463485c6b75904a5951ca

Diff:

Revision 4 (+12 -1)

Show changes

reviewboard/webapi/resources/root.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/root.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/root.py

Ship it!

```
Ship It!
```

Review Board 7.0 alpha 0 (dev)

rswanson got a fish trophy!

Integrating Extension mixin in to RB root resource

Information

Reviewers

Commit:

Diff:

Summary:

Description:

Commit:

Diff:

Commit:

Diff:

Status: Discarded