Fish Trophy

rswanson got a fish trophy!

Integrating Extension mixin in to RB root resource

Review Request #8448 — Created Sept. 29, 2016 and updated

rswanson
Review Board
master
f8c64ce...
reviewboard, students

Integrating Extension mixin in to RB root resource



Description From Last Updated

You can just import this as ExtensionRootResourceMixin. There is no reason to rename it. We rename the DjbletsRootResource because otherwise ...

brenniebrennie

Must be in alphabetical order.

chipx86chipx86

Mixins should actually go first in the list.

chipx86chipx86

Docstring.

brenniebrennie

Col: 1 E101 indentation contains mixed spaces and tabs

reviewbotreviewbot

Col: 1 W191 indentation contains tabs

reviewbotreviewbot

Col: 6 E128 continuation line under-indented for visual indent

reviewbotreviewbot
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/root.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/root.py
    
    
  2. 
      
brennie
  1. 
      
  2. reviewboard/webapi/resources/root.py (Diff revision 1)
     
     
     

    You can just import this as ExtensionRootResourceMixin. There is no reason to rename it. We rename the DjbletsRootResource because otherwise we would be redefining RootResource.

  3. 
      
RS
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/root.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/root.py
    
    
  2. 
      
brennie
  1. 
      
  2. reviewboard/webapi/resources/root.py (Diff revision 2)
     
     

    Docstring.

  3. 
      
RS
RS
chipx86
  1. This is missing a fleshed out description and testing. I should be able to look at this change with no knowledge of what you're working on, and walk away with a good sense of why this change matters.

  2. reviewboard/webapi/resources/root.py (Diff revision 2)
     
     
     
     

    Must be in alphabetical order.

  3. reviewboard/webapi/resources/root.py (Diff revision 2)
     
     
     

    Mixins should actually go first in the list.

  4. 
      
RS
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/root.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/root.py
    
    
  2. reviewboard/webapi/resources/root.py (Diff revision 3)
     
     
    Col: 1
     E101 indentation contains mixed spaces and tabs
    
  3. reviewboard/webapi/resources/root.py (Diff revision 3)
     
     
    Col: 1
     W191 indentation contains tabs
    
  4. reviewboard/webapi/resources/root.py (Diff revision 3)
     
     
    Col: 6
     E128 continuation line under-indented for visual indent
    
  5. 
      
RS
Review request changed

Commit:

-cf98adaf55681d73ab8ec1b1a016f8948970344c
+f8c64ce33028ee93d84463485c6b75904a5951ca

Diff:

Revision 4 (+12 -1)

Show changes

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/root.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/root.py
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
Loading...