Refactor out the code for centering diff collapse buttons

Review Request #8444 — Created Sept. 27, 2016 and submitted

Information

Review Board
release-3.0.x
d1df202...

Reviewers

The code for centering diff collapse buttons has been refactored into the
RB.CenteredElementManager. This view centres a set of elements within
their respective container elements.

Verified the collapsable diff context and diff viewer collapse buttons
still centred correctly.

Description From Last Updated

In your summary/description, you have a variety of spellings of "center". I guess "centring" is maybe Canadian, but the implementation …

daviddavid

This function doesn't take any args (anymore?)

daviddavid

Doc comment?

daviddavid

Doc comment?

daviddavid

Doc comment?

daviddavid

Doc comment?

daviddavid

Doc comment?

daviddavid

Trailing comma?

daviddavid

Can we call the parameter elements instead of els?

daviddavid

There's an extra blank line here.

daviddavid
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/ui/views/centeredElementManager.es6.js
        reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
        reviewboard/static/rb/js/views/diffFragmentQueueView.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/ui/views/centeredElementManager.es6.js
        reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
        reviewboard/static/rb/js/views/diffFragmentQueueView.js
    
    
  2. 
      
david
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/ui/views/centeredElementManager.es6.js
        reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
        reviewboard/static/rb/js/views/diffFragmentQueueView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/ui/views/centeredElementManager.es6.js
        reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
        reviewboard/static/rb/js/views/diffFragmentQueueView.js
    
    
  2. 
      
david
  1. 
      
  2. In your summary/description, you have a variety of spellings of "center". I guess "centring" is maybe Canadian, but the implementation in the code uses "centered", and "centeres" just seems incorrect. I'd prefer "centered" / "centers" / "centering".

    And now none of those look like words =P

  3. Can we call the parameter elements instead of els?

  4. 
      
brennie
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/ui/views/centeredElementManager.es6.js
        reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
        reviewboard/static/rb/js/views/diffFragmentQueueView.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/ui/views/centeredElementManager.es6.js
        reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
        reviewboard/static/rb/js/views/diffFragmentQueueView.js
    
    
  2. 
      
david
  1. 
      
  2. There's an extra blank line here.

  3. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (a080b44)
Loading...