Refactor out the code for centering diff collapse buttons
Review Request #8444 — Created Sept. 27, 2016 and submitted
The code for centering diff collapse buttons has been refactored into the
RB.CenteredElementManager. This view centres a set of elements within
their respective container elements.
Verified the collapsable diff context and diff viewer collapse buttons
still centred correctly.
| Description | From | Last Updated |
|---|---|---|
|
In your summary/description, you have a variety of spellings of "center". I guess "centring" is maybe Canadian, but the implementation … |
 david
|
|
|
This function doesn't take any args (anymore?) |
david
|
|
|
Doc comment? |
david
|
|
|
Doc comment? |
david
|
|
|
Doc comment? |
david
|
|
|
Doc comment? |
david
|
|
|
Doc comment? |
david
|
|
|
Trailing comma? |
david
|
|
|
Can we call the parameter elements instead of els? |
david
|
|
|
There's an extra blank line here. |
david
|
- Change Summary:
-
Addressed David's issues.
- Commit:
-
311e1327201118f012c1d6c4939c85315e1af4f67077b2f2dc560bf369074fa70a0c5d0484c2064a
-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/ui/views/centeredElementManager.es6.js reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js reviewboard/static/rb/js/views/diffFragmentQueueView.js Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/ui/views/centeredElementManager.es6.js reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js reviewboard/static/rb/js/views/diffFragmentQueueView.js
- Change Summary:
-
De-Canadian-ised (:P) the description and summary. Addressed David's issues.
- Summary:
-
Refactor out the code for centring diff collapse buttonsRefactor out the code for centering diff collapse buttons
- Description:
-
~ The code for centring diff collapse buttons has been refactored into the
~ RB.CenteredElementManager. This view centeres a set of elements within~ The code for centering diff collapse buttons has been refactored into the
~ RB.CenteredElementManager. This view centres a set of elements withintheir respective container elements.
- Change Summary:
-
Actually publish changes
- Commit:
-
7077b2f2dc560bf369074fa70a0c5d0484c2064ad1df202430a8c8597dd4a427ab31a1eee64a03e9
-
Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/ui/views/centeredElementManager.es6.js reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js reviewboard/static/rb/js/views/diffFragmentQueueView.js Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/ui/views/centeredElementManager.es6.js reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js reviewboard/static/rb/js/views/diffFragmentQueueView.js
Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/ui/views/centeredElementManager.es6.js reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js reviewboard/static/rb/js/views/diffFragmentQueueView.js Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/ui/views/centeredElementManager.es6.js reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js reviewboard/static/rb/js/views/diffFragmentQueueView.js