Add previous and next buttons to navigate between file attachments
Review Request #8443 — Created Sept. 27, 2016 and submitted
The file attachment UI previously did not have any way to navigate
between any file attachments. A user would have to navigate back to the
review request and select the next one they wished to review.Now there are previous and next buttons on the edges of the page when
there are more file attachments to review. They follow the order of the
review request UI and only navigate to active (and latest revisions).
When they are hovered over, they expand out to show the thumbnail of the
attachment that will be navigated to.
Ran unit tests.
Tested in the following browsers on OSX:
- Chrome
- Firefox release
- Firefox developer edition
- Safari
Verified the links were correct on local site review requests.
| Description | From | Last Updated |
|---|---|---|
|
Can you show screenshots/add Testing Done for this on both Firefox (stable) and Chrome? |
chipx86
|
|
|
Can you also test with Local Sites to make sure links are correct? |
chipx86
|
|
|
Can we give this a bit of a box-shadow so that the layering is more apparent? |
david
|
|
|
It might be nice to break this out into a method, or at least comment it and explain what it's … |
david
|
|
|
Perhaps we can change get_latest_file_attachments to return a generator expression instead of a list? |
david
|
|
|
I don't think this change is correct. |
david
|
|
|
Where does the 14px come from? |
david
|
|
|
There's an extra space before this templatetag. |
david
|
|
|
This is all indented 1 space too much. |
david
|
|
|
Indented 1 space too much. |
david
|
|
|
undefined name 'next_obj' |
reviewbot
|
|
|
undefined name 'prev_obj' |
reviewbot
|
|
|
Col: 80 E501 line too long (117 > 79 characters) |
reviewbot
|
|
|
It might be nice to say what "next" and "previous" mean. |
david
|
|
|
Col: 80 E501 line too long (117 > 79 characters) |
reviewbot
|
|
|
Can we define a constant for this? |
david
|
|
|
Col: 80 E501 line too long (117 > 79 characters) |
reviewbot
|
|
|
If we made a change to have @page-container-padding be in px instead of em, we could use LESS's calculations here … |
david
|
|
|
Col: 80 E501 line too long (117 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (117 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (117 > 79 characters) |
reviewbot
|
|
|
Should be: Yields: reviewboard.attachments.models.FileAttachment ... |
chipx86
|
|
|
Col: 80 E501 line too long (117 > 79 characters) |
reviewbot
|
|
|
Swap these. Elements before classes. (Elements, then IDs, then classes.) |
chipx86
|
|
|
Swap these. |
chipx86
|
|
|
Two blank lines. |
chipx86
|
|
|
You shouldn't need to use the "localsite" template tag for anything. The url tag from there is automatically injected globally … |
chipx86
|
|
|
We want to use the display ID, not the database ID, for review requests on these URLs. |
chipx86
|
|
|
Col: 80 E501 line too long (117 > 79 characters) |
reviewbot
|
Review request changed
- Change Summary:
-
Addressed David's issues. Made the code more compatible with IE
- Commit:
-
305608c07b673d00cbcf99b8ce44d360d3ab8d3db9b11aea2e630ba0aabb11367a0f6a701042f93f
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/attachments/models.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/css/pages/reviews.less Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/attachments/models.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/css/pages/reviews.less -
-
-
Review request changed
- Change Summary:
-
Cleanup.
- Commit:
-
b9b11aea2e630ba0aabb11367a0f6a701042f93f49994c758a8899b6c937f07e83f0104b37a12c60
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/attachments/models.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/css/pages/reviews.less Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/attachments/models.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/css/pages/reviews.less -
Review request changed
- Change Summary:
-
Addressed David's issues.
- Commit:
-
49994c758a8899b6c937f07e83f0104b37a12c60e38efba14f7a8bdfad7e580830bc4b3339733dd0
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/attachments/models.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/css/pages/reviews.less Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/attachments/models.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/css/pages/reviews.less -
Review request changed
- Change Summary:
-
Addressed David's issue
- Commit:
-
e38efba14f7a8bdfad7e580830bc4b3339733dd0f3d456a53e9cea1547c6ed17b8b397dd1d89c450
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/attachments/models.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/css/pages/reviews.less Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/attachments/models.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/css/pages/reviews.less -
Review request changed
- Change Summary:
-
Fix attachment order and variable interpolation
- Commit:
-
f3d456a53e9cea1547c6ed17b8b397dd1d89c450b15785ccb57e0389347aac9c12607e477baf15a6
- Diff:
-
Revision 6 (+166 -22)
- Removed Files:
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/attachments/models.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/css/pages/reviews.less Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/attachments/models.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/css/pages/reviews.less -
Review request changed
- Commit:
-
b15785ccb57e0389347aac9c12607e477baf15a6c8889b753c656305c53afbad26df97b913072570
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/attachments/models.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/css/pages/reviews.less Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/attachments/models.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/css/pages/reviews.less -
Review request changed
- Change Summary:
-
Refactored out CSS
calc()expression.
Decreased padding and font size of chevrons so they dont go off the sides of the page. - Removed Files:
- Added Files:
Review request changed
- Commit:
-
c8889b753c656305c53afbad26df97b913072570b0f839e110f0b23fd2f61c9e10c212161cfe7cfd
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/attachments/models.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/css/pages/reviews.less Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/attachments/models.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/css/pages/reviews.less -
Review request changed
- Testing Done:
-
~ - Ran unit tests.
~ - Navigated between file attachments. Saw that navigation occurred
correctly.
~ Ran unit tests.
~ + Tested in the following browsers on OSX:
+ + - Chrome
+ - Firefox release
+ - Firefox developer edition
+ - Safari
+ + Verified the links were correct on local site review requests.
- Commit:
-
b0f839e110f0b23fd2f61c9e10c212161cfe7cfd0992759f3e75e6ec483b4c999e15452798cd7e61
- Diff:
-
Revision 9 (+167 -21)
- Removed Files:
- Added Files:
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/attachments/models.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/css/pages/reviews.less Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/attachments/models.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/css/pages/reviews.less -
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/attachments/models.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/css/pages/reviews.less Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/ui/base.py reviewboard/attachments/models.py Ignored Files: reviewboard/templates/reviews/ui/base.html reviewboard/static/rb/css/pages/reviews.less