Add unit tests for rb_auto_assigner.

Review Request #8438 — Created Sept. 25, 2016 and submitted

mike_conley
student-sonar
master
8435
ec55779...
student-sonar
Add unit tests for rb_auto_assigner.

Ran these tests, and they all pass.

Description From Last Updated

These should be together. Also missing from __future__ import unicode_literals. Also missing file docstring.

brenniebrennie

Class docstring missing.

brenniebrennie

blank line between these.

brenniebrennie

list of string

brenniebrennie

Oops, I said string but I meant unicode. Sorry.

brenniebrennie

"Test"

brenniebrennie

mconley doesn't exist as a user, no?

brenniebrennie

"Test"

brenniebrennie

"Test"

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py
    
    
  2. 
      
mike_conley
brennie
  1. 
      
  2. These should be together.

    Also missing from __future__ import unicode_literals.

    Also missing file docstring.

  3. Class docstring missing.

  4. mconley doesn't exist as a user, no?

    1. Correct, and neither does someone_else. This test is making sure that if there are names in the auto-assign list, if a submitter is not in the list, that they're not auto-assigned.

      Or am I missing another problem here?

  5. 
      
mike_conley
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py
    
    
  2. 
      
brennie
  1. 
      
  2. blank line between these.

  3. Oops, I said string but I meant unicode. Sorry.

  4. 
      
mike_conley
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        misc/rb-auto-assigner/rb_auto_assigner/tests/test_basic.py
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
mike_conley
Review request changed

Status: Closed (submitted)

Change Summary:

Landed in 295eb6cd.

Loading...