Summary

[WIP] Create a new Review Request after creating a PR on Github

Review Request #8437 — Created Sept. 25, 2016 and discarded Oct. 26, 2021, 12:16 p.m.

Information

Owner

finaiized

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This is mainly exploratory code.

Add support for automatically creating a review request
from a pull request.

Step one in integrating pull requests with Reviewboard is
to first create the review request when a PR happens.
For now, we provide support only for Github.

To set up the webhook, first make sure your repository
is linked to Reviewboard. Then, in your repo's settings on Github,
select 'Webhooks' and add
repos/{repo_num}/github/hooks/close-submitted/.
Make sure to unselect 'Push' and select 'Pull Request' for the event
you'd like to know about.

A new review request should now be created, and the ID of the pull request
that the review request was created from should be displayed on the
"Information" panel.

Note that if you're testing locally, you should
set up localtunnel
to foward your request.

Now when you make a commit, a review request should
be created automatically.

Still to do * Sync more data like branch info * Import diffs from the PR * Link user from Github to Reviewboard (and handle cases where it doesn't exist)

Testing Done

Issues

Description	From	Last Updated
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Sept. 25, 2016, 7:36 a.m.
local variable 'e' is assigned to but never used	reviewbot	Sept. 25, 2016, 7:36 a.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	Oct. 6, 2016, 7:21 p.m.
local variable 'e' is assigned to but never used	reviewbot	Oct. 6, 2016, 7:21 p.m.
Col: 80 E501 line too long (100 > 79 characters)	reviewbot	Oct. 6, 2016, 7:21 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 6, 2016, 7:21 p.m.

Fix it!

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/github.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/github.py

reviewboard/hostingsvcs/github.py (Diff revision 1)
Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
reviewboard/hostingsvcs/github.py (Diff revision 1)
Show all issues
```
 local variable 'e' is assigned to but never used
```

Description:

		This is mainly exploratory code.

~		Add support for automatically creating a review request from a pull request.
	~	Add support for automatically creating a review request
	+	from a pull request.

~		Step one in integrating pull requests with Reviewboard is to first create the review request when a PR happens. For now, we provide support only for Github. Instead of listening for pull requests, we currently listen for commits, because that is easier to test.
	~	Step one in integrating pull requests with Reviewboard is
	+	to first create the review request when a PR happens.
	+	For now, we provide support only for Github. Instead of
	+	listening for pull requests, we currently listen for commits,
	+	because that is easier to test.

~		To set up the webhook, first make sure your repository is linked to Reviewboard. Then, in your repo's settings on Github, select 'Webhooks' and add `repos/{repo_num}/github/hooks/close-submitted/`. Note that if you're testing locally, you should set up localtunnel to foward your request.
	~	To set up the webhook, first make sure your repository
	+	is linked to Reviewboard. Then, in your repo's settings on Github,
	+	select 'Webhooks' and add
	+	`repos/{repo_num}/github/hooks/close-submitted/`.
	+	Note that if you're testing locally, you should
	+	set up localtunnel
	+	to foward your request.

~		Now when you make a commit, a review request should be created automatically.
	~	Now when you make a commit, a review request should
	+	be created automatically.

		Still to do
		* Switch over to listening for PR creation over commits
		* Sync more data like branch info
		* Add a PR field that links back to the PR that created the review request
		* Import diffs from the PR
		* Link user from Github to Reviewboard (and handle cases where it doesn't exist)

Change Summary:


Listen for Github's pull request webhook and create a new RR from it.
Show the pull request ID in the "Information" panel when the RR is created from a RR.
Set the summary and description of the RR from the PR's title and details.

Description:

		This is mainly exploratory code.

		Add support for automatically creating a review request
		from a pull request.

		Step one in integrating pull requests with Reviewboard is
		to first create the review request when a PR happens.
~		For now, we provide support only for Github. Instead of
	~	For now, we provide support only for Github.
-		listening for pull requests, we currently listen for commits,
-		because that is easier to test.

		To set up the webhook, first make sure your repository
		is linked to Reviewboard. Then, in your repo's settings on Github,
		select 'Webhooks' and add
		`repos/{repo_num}/github/hooks/close-submitted/`.
~		Note that if you're testing locally, you should
	~	Make sure to unselect 'Push' and select 'Pull Request' for the event
	+	you'd like to know about.
	+
	+	A new review request should now be created, and the ID of the pull request
	+	that the review request was created from should be displayed on the
	+	"Information" panel.
	+
	+	Note that if you're testing locally, you should
		set up localtunnel
		to foward your request.

		Now when you make a commit, a review request should
		be created automatically.

		Still to do
-		* Switch over to listening for PR creation over commits
		* Sync more data like branch info
-		* Add a PR field that links back to the PR that created the review request
		* Import diffs from the PR
		* Link user from Github to Reviewboard (and handle cases where it doesn't exist)

Commit:

-	f9f515b04932853eefc5e466032d0bc5327ae36b
+	a3f64e2779a65bef14568d21b80b6ad7999926e5

Diff:

Revision 2 (+95 -4)

Show changes

	reviewboard/hostingsvcs/github.py
	reviewboard/reviews/builtin_fields.py
	reviewboard/reviews/models/review_request.py

Fix it!

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/builtin_fields.py
    reviewboard/hostingsvcs/github.py
    reviewboard/reviews/models/review_request.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/builtin_fields.py
    reviewboard/hostingsvcs/github.py
    reviewboard/reviews/models/review_request.py

reviewboard/hostingsvcs/github.py (Diff revision 2)
Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
Show all issues
```
 local variable 'e' is assigned to but never used
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
Show all issues
```
Col: 80
 E501 line too long (100 > 79 characters)
```
reviewboard/reviews/builtin_fields.py (Diff revision 2)
Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```

Review Board 6.0.1 alpha 0 (dev)

[WIP] Create a new Review Request after creating a PR on Github

Information

Reviewers

Description:

Change Summary:

Description:

Commit:

Diff:

Status: Discarded