-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 1) local variable 'e' is assigned to but never used
[WIP] Create a new Review Request after creating a PR on Github
Review Request #8437 — Created Sept. 25, 2016 and discarded
This is mainly exploratory code.
Add support for automatically creating a review request
from a pull request.Step one in integrating pull requests with Reviewboard is
to first create the review request when a PR happens.
For now, we provide support only for Github.To set up the webhook, first make sure your repository
is linked to Reviewboard. Then, in your repo's settings on Github,
select 'Webhooks' and add
repos/{repo_num}/github/hooks/close-submitted/
.
Make sure to unselect 'Push' and select 'Pull Request' for the event
you'd like to know about.A new review request should now be created, and the ID of the pull request
that the review request was created from should be displayed on the
"Information" panel.Note that if you're testing locally, you should
set up localtunnel
to foward your request.Now when you make a commit, a review request should
be created automatically.Still to do * Sync more data like branch info * Import diffs from the PR * Link user from Github to Reviewboard (and handle cases where it doesn't exist)
Description | From | Last Updated |
---|---|---|
Col: 80 E501 line too long (85 > 79 characters) |
![]() |
|
local variable 'e' is assigned to but never used |
![]() |
|
Col: 80 E501 line too long (82 > 79 characters) |
![]() |
|
local variable 'e' is assigned to but never used |
![]() |
|
Col: 80 E501 line too long (100 > 79 characters) |
![]() |
|
Col: 80 E501 line too long (81 > 79 characters) |
![]() |
Description: |
|
---|
Change Summary:
- Listen for Github's pull request webhook and create a new RR from it.
- Show the pull request ID in the "Information" panel when the RR is created from a RR.
- Set the summary and description of the RR from the PR's title and details.
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+95 -4) |

-
Tool: Pyflakes Processed Files: reviewboard/reviews/builtin_fields.py reviewboard/hostingsvcs/github.py reviewboard/reviews/models/review_request.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/builtin_fields.py reviewboard/hostingsvcs/github.py reviewboard/reviews/models/review_request.py
-
-
reviewboard/hostingsvcs/github.py (Diff revision 2) local variable 'e' is assigned to but never used
-
reviewboard/hostingsvcs/github.py (Diff revision 2) Col: 80 E501 line too long (100 > 79 characters)
-
reviewboard/reviews/builtin_fields.py (Diff revision 2) Col: 80 E501 line too long (81 > 79 characters)