• 
      

    Make sure test runner is imported after setting environment up.

    Review Request #8435 — Created Sept. 24, 2016 and submitted

    Information

    Review Board
    master
    008b6d4...

    Reviewers

    We were importing the extension test runner before setting the
    RB_RUNNING_TESTS environment variable which meant that the instance of
    Review Board used for testing would have the wrong configuration
    to start. Specifically, the RUNNING_TESTS setting was set to the
    wrong value, causing parts of the codebase to be unaware that they
    were running in a test environment, which caused them to set up
    some defaults in the database that conflicted with the test fixtures.

    Wrote a simple test for an extension and ran it successfully.

    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/cmdline/rbext.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/cmdline/rbext.py
      
      
    2. 
        
    mike_conley
    david
    1. Ship It!
    2. 
        
    mike_conley
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (0f8b0db)