Fix a bad regression with the review group form.

Review Request #8430 — Created Sept. 24, 2016 and submitted

Information

Review Board
release-2.5.x
8da4f15...

Reviewers

Due to a quirk in the way forms are initialized, the review group form was
losing the "name" and "display name" fields before validation. This caused
saving new items to always fail.

Passing the local_site_name all the way through kwargs fixes the issue. I've
applied the same fix to the DefaultReviewerForm, and made both call the
superclass' clean method, just for completeness.

Was able to save new review groups and default reviewers.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/forms.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/forms.py
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (8f7086b)
Loading...