Summary

Do a bunch of clean-up work for Review Bot.

Review Request #8423 — Created Sept. 20, 2016 and submitted Oct. 7, 2016, 10:09 a.m.

Information

Owner

david

Repository

ReviewBot

Branch

master

Bugs

Depends On

Commit

b52d471...

Reviewers

Groups

reviewbot

People

Description

In preparation for some modernization, I'm doing a little bit of clean-up (and
familiarizing myself with the codebase). This change primarily adds
unicode_literals and fixes up docstrings, though there are a few places where
I've made things more idiomatic or simpler.

Testing Done

Verified that the extension loaded correctly. Looked at the various forms in
the admin UI.

Issues

Description	From	Last Updated
Blank line between these.	brennie	Oct. 3, 2016, 1:12 p.m.
Blank line between these.	brennie	Oct. 3, 2016, 1:12 p.m.
Blank line ebtween these.	brennie	Oct. 3, 2016, 1:12 p.m.
Can we pull this out into a variable?	brennie	Oct. 3, 2016, 1:12 p.m.
Do we want this to be @py2_unicode_compatiable (so __str__ also works?	brennie	Oct. 3, 2016, 1:13 p.m.
You can add an Attributes section, like Args in method definitions. e.g. """... Attributes: tool_options (type of tool_options): Description """	brennie	Oct. 3, 2016, 1:17 p.m.
Blank line between these.	brennie	Oct. 3, 2016, 1:14 p.m.
Do we want this to be @py2_unicode_compatiable (so __str__ also works?	brennie	Oct. 3, 2016, 1:14 p.m.
Blank line between these.	brennie	Oct. 3, 2016, 1:14 p.m.
Do we want this to be @py2_unicode_compatiable (so __str__ also works?	brennie	Oct. 3, 2016, 1:14 p.m.
Blank line between these.	brennie	Oct. 3, 2016, 1:14 p.m.
Do we want this to be @py2_unicode_compatiable (so __str__ also works?	brennie	Oct. 3, 2016, 1:14 p.m.
Exception as e? Do we want to limit to Python 2.6+ ?	brennie	Oct. 7, 2016, 10:07 a.m.

extension/reviewbotext/admin.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
extension/reviewbotext/admin.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
extension/reviewbotext/admin.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line ebtween these.
```

extension/reviewbotext/forms.py (Diff revision 1)

The issue has been dropped. Show all issues

Can we pull this out into a variable?

david Oct. 3, 2016, 1:27 p.m.

I don't care enough because I'm actually going to be removing this code.

extension/reviewbotext/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Do we want this to be @py2_unicode_compatiable (so __str__ also works?
```

extension/reviewbotext/models.py (Diff revision 1)

The issue has been resolved. Show all issues

You can add an Attributes section, like Args in method definitions.

e.g.

"""...

Attributes:
    tool_options (type of tool_options):
        Description
"""

david Oct. 3, 2016, 1:27 p.m.
```
Going to use a #: comment instead.
```

extension/reviewbotext/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
extension/reviewbotext/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Do we want this to be @py2_unicode_compatiable (so __str__ also works?
```
extension/reviewbotext/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
extension/reviewbotext/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Do we want this to be @py2_unicode_compatiable (so __str__ also works?
```
extension/reviewbotext/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
extension/reviewbotext/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Do we want this to be @py2_unicode_compatiable (so __str__ also works?
```

Commit:

-	384c359416756d7bf10c2c233276eb63d48d7fa0
+	b52d471afcc46851ebe28ab4c7de0a3d2b8f9df0

Diff:

Revision 2 (+327 -180)

Show changes

	extension/setup.cfg
	extension/reviewbotext/__init__.py
	extension/reviewbotext/admin.py
	extension/reviewbotext/admin_urls.py
	extension/reviewbotext/extension.py
	extension/reviewbotext/forms.py
	extension/reviewbotext/handlers.py
	extension/reviewbotext/managers.py
	3 more

Tool: PEP8 Style Checker
Processed Files:
    extension/reviewbotext/extension.py
    extension/reviewbotext/admin_urls.py
    extension/reviewbotext/managers.py
    extension/reviewbotext/__init__.py
    extension/reviewbotext/admin.py
    extension/reviewbotext/forms.py
    extension/reviewbotext/handlers.py
    extension/reviewbotext/resources.py
    extension/reviewbotext/models.py

Ignored Files:
    extension/setup.cfg
    extension/reviewbotext/templates/admin/reviewbotext/tool/change_form.html



Tool: Pyflakes
Processed Files:
    extension/reviewbotext/extension.py
    extension/reviewbotext/admin_urls.py
    extension/reviewbotext/managers.py
    extension/reviewbotext/__init__.py
    extension/reviewbotext/admin.py
    extension/reviewbotext/forms.py
    extension/reviewbotext/handlers.py
    extension/reviewbotext/resources.py
    extension/reviewbotext/models.py

Ignored Files:
    extension/setup.cfg
    extension/reviewbotext/templates/admin/reviewbotext/tool/change_form.html

Ship it!

extension/reviewbotext/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Exception as e?

Do we want to limit to Python 2.6+ ?
```
1. david Oct. 6, 2016, 5:15 p.m.
  Review Bot 1.0 will be Review Board 3.0+ only, so yes.

Status: Closed (submitted)

Change Summary:

Pushed to master (365ebfe)