Setting a default 'is_rr_approved' value for land command outside try block.

Review Request #8404 — Created Sept. 18, 2016 and discarded

rswanson
RBTools
release-0.7.x
rbtools, students

Currently, 'is_rr_approved' may not be set during execution of RBTools' land command
if an Exception other than AttributeError is encountered.

This change introduces default values to `is_rr_approved` and `approval_failure` before
attempting to retrieve information from the review request. In the event an exception is
encountered, RBTools will fail gracefully without disclosing a stack trace.

Bug ticket: https://hellosplat.com/s/beanbag/tickets/4024/

Testing Done: Ran the land command a few times and observed its functionality.

david
  1. It looks like you should have updated /r/8401 rather than created a new review request here. Can you discard one or the other?

    1. Yup - I misused the rbt post command. I'll close out this request.

  2. 
      
RS
Review request changed

Status: Discarded

Loading...